Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: add test case for completion bash flag #24168
Conversation
nodejs-github-bot
added
the
test
label
Nov 6, 2018
bengl
approved these changes
Nov 6, 2018
BridgeAR
approved these changes
Nov 6, 2018
BridgeAR
added
the
code-and-learn
label
Nov 6, 2018
jasnell
approved these changes
Nov 10, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
landed as 288076d thank you @aivopaas for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps |
gireeshpunathil
closed this
Nov 11, 2018
gireeshpunathil
added a commit
that referenced
this pull request
Nov 11, 2018
BridgeAR
added a commit
that referenced
this pull request
Nov 14, 2018
kiyomizumia
added a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This was referenced Nov 15, 2018
codebytere
added a commit
that referenced
this pull request
Dec 14, 2018
codebytere
added a commit
that referenced
this pull request
Dec 14, 2018
MylesBorins
added a commit
that referenced
this pull request
Dec 26, 2018
This was referenced Jan 29, 2019
This was referenced Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
aivopaas commentedNov 6, 2018
This test case verifies that starting Node.js with the completion
bash flag prints out the expected result and ends right after.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes