★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24162Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add else and error case for TextDecoder #24162

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@addaleax addaleax

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
code-and-learn test
Projects
None yet
Milestone
No milestone
7 participants
@lauripiisang @addaleax @gireeshpunathil @jasnell @cjihrig @BridgeAR @nodejs-github-bot
@lauripiisang
Copy link
Contributor

lauripiisang commented Nov 6, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lauripiisang
test: add else and error case for TextDecoder 
 - add test for tinyurl.com/codeandlearn-encoding-1
 - add test for tinyurl.com/codeandlearn-encoding-2
Loading status checks…
079e614

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@lauripiisang

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

lauripiisang commented Nov 6, 2018

@jasnell : LGTM
@addaleax

addaleax approved these changes Nov 6, 2018
View changes

@addaleax addaleax added the code-and-learn label Nov 6, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18372/
@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@BridgeAR

BridgeAR approved these changes Nov 6, 2018
View changes

@jasnell

jasnell approved these changes Nov 10, 2018
View changes

Copy link
Member

jasnell left a comment

Confirming my LGTM
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 12, 2018

landed as 1d9ba7b

thank you @lauripiisang for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

@gireeshpunathil gireeshpunathil closed this Nov 12, 2018

gireeshpunathil added a commit that referenced this pull request Nov 12, 2018

@lauripiisang @gireeshpunathil
test: add else and error case for TextDecoder 
add test for tinyurl.com/codeandlearn-encoding-1
add test for tinyurl.com/codeandlearn-encoding-2

PR-URL: #24162
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Loading status checks…
1d9ba7b

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@lauripiisang @BridgeAR
test: add else and error case for TextDecoder 
add test for tinyurl.com/codeandlearn-encoding-1
add test for tinyurl.com/codeandlearn-encoding-2

PR-URL: #24162
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
77163a9

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@lauripiisang @kiyomizumia
test: add else and error case for TextDecoder 
add test for tinyurl.com/codeandlearn-encoding-1
add test for tinyurl.com/codeandlearn-encoding-2

PR-URL: nodejs#24162
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
bd43ef8

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 12, 2019

@lauripiisang @codebytere
test: add else and error case for TextDecoder 
add test for tinyurl.com/codeandlearn-encoding-1
add test for tinyurl.com/codeandlearn-encoding-2

PR-URL: #24162
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
e21d784

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Jan 30, 2019

Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.