test: check for invalid importModuleDynamically type in vm.js #24161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 6, 2018
2 tasks
BridgeAR
approved these changes
Nov 6, 2018
jasnell
approved these changes
Nov 10, 2018
gireeshpunathil
reviewed
Nov 12, 2018
| 'import("foo")', | ||
| { importModuleDynamically: false }), | ||
| { code: 'ERR_INVALID_ARG_TYPE' } | ||
| ) |
There was a problem hiding this comment.
linter failed due to missing semicolon here; @alyssaq - can you please make that change?
gireeshpunathil
approved these changes
Nov 13, 2018
|
landed as dde9b3a , thanks! |
gireeshpunathil
added a commit
that referenced
this issue
Nov 13, 2018
PR-URL: #24161 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
added a commit
that referenced
this issue
Nov 14, 2018
PR-URL: #24161 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia
added a commit
to kiyomizumia/node
that referenced
this issue
Nov 15, 2018
PR-URL: nodejs#24161 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Added test for checking the thrown error when the option
importModuleDynamicallyis not a function.