★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24156Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: net eaddrinuse, change arguments order in strictEqual #24156

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
backported-to-v10.x code-and-learn test
Projects
None yet
Milestone
No milestone
9 participants
@Paul-Isache @trivikr @gireeshpunathil @Trott @cjihrig @BridgeAR @addaleax @codebytere @nodejs-github-bot
@Paul-Isache
Copy link
Contributor

Paul-Isache commented Nov 6, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@BridgeAR

BridgeAR approved these changes Nov 6, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 6, 2018
View changes

@addaleax addaleax added the code-and-learn label Nov 6, 2018

@trivikr

trivikr approved these changes Nov 7, 2018
View changes

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Nov 7, 2018

Hi @Paul-Isache, the author of this commit is not registered on Github (steps defined here)

Either:

  • add the email ID associated with the commit to Github
  • change the author of the commit to current email ID registered with the Github by following these steps

@Paul-Isache Paul-Isache force-pushed the Paul-Isache:test-net-eaddrinuse branch from 97aeb47 to e32c2ca Nov 7, 2018

@Paul-Isache

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Paul-Isache commented Nov 7, 2018

Hi @trivikr,
I modified the author of the commit with the email that I am registered with.
@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Nov 7, 2018

Thanks @Paul-Isache, confirmed that it looks good!
@trivikr

trivikr approved these changes Nov 7, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18439/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 10, 2018

failures in arm and smart-os platforms seen yesterday, looks like some infra issues that got fixed.

resume CI: https://ci.nodejs.org/job/node-test-pull-request/18484/

Trott added a commit to Trott/io.js that referenced this pull request Nov 10, 2018

@Paul-Isache @Trott
test: change arguments order in strictEqual 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: nodejs#24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
a67e0a6
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 10, 2018

Landed in a67e0a6.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 10, 2018

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@Paul-Isache @amel-true
test: change arguments order in strictEqual 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: nodejs#24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
a6323a4

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@Paul-Isache @rangle-tadhg
test: change arguments order in strictEqual 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: nodejs#24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
5ab8289

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@Paul-Isache @BridgeAR
test: change arguments order in strictEqual 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: #24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
0c4facf

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@Paul-Isache @kiyomizumia
test: change arguments order in strictEqual 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: nodejs#24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
74ea574

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 13, 2018

@Paul-Isache @codebytere
test: change arguments order in strictEqual 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: #24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
Loading status checks…
b264d7e

@codebytere codebytere added the backported-to-v10.x label Dec 13, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@Paul-Isache @MylesBorins
test: change arguments order in strictEqual 
Fix actual/expected ordering in test-net-eaddrinuse.

PR-URL: #24156
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d7a3a3b

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.