★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24155Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix arguments order in test-fs-write-buffer #24155

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
backported-to-v10.x code-and-learn test
Projects
None yet
Milestone
No milestone
7 participants
@razvanbh @mhdawson @gireeshpunathil @cjihrig @BridgeAR @codebytere @nodejs-github-bot
@razvanbh
Copy link
Contributor

razvanbh commented Nov 6, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@mhdawson mhdawson added the code-and-learn label Nov 6, 2018

@mhdawson

This comment has been minimized.

Sign in to view
Copy link
Member

mhdawson commented Nov 6, 2018

LGTM
@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 6, 2018
View changes

@BridgeAR

BridgeAR approved these changes Nov 6, 2018
View changes

@razvanbh razvanbh force-pushed the razvanbh:fix-arguments-order branch from d5e7ee5 to 89e2a7d Nov 7, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18438/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 9, 2018

landed as 52c548b

thank you @razvanbh for the contribution. Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps/

@gireeshpunathil gireeshpunathil closed this Nov 9, 2018

gireeshpunathil added a commit that referenced this pull request Nov 9, 2018

@razvanbh @gireeshpunathil
test: fix arguments order in test-fs-write-buffer 
PR-URL: #24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Loading status checks…
52c548b

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@razvanbh @amel-true
test: fix arguments order in test-fs-write-buffer 
PR-URL: nodejs#24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
5f52a62

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@razvanbh @rangle-tadhg
test: fix arguments order in test-fs-write-buffer 
PR-URL: nodejs#24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
cddb783

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@razvanbh @BridgeAR
test: fix arguments order in test-fs-write-buffer 
PR-URL: #24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
3179011

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@razvanbh @kiyomizumia
test: fix arguments order in test-fs-write-buffer 
PR-URL: nodejs#24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1e8b0c4

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 13, 2018

@razvanbh @codebytere
test: fix arguments order in test-fs-write-buffer 
PR-URL: #24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
30d9588

@codebytere codebytere added the backported-to-v10.x label Dec 13, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@razvanbh @MylesBorins
test: fix arguments order in test-fs-write-buffer 
PR-URL: #24155
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
90f9890

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.