★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24140Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixes order of arguments in assert.strictEqual #24140

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
backported-to-v10.x code-and-learn test
Projects
None yet
Milestone
No milestone
8 participants
@posth @gireeshpunathil @addaleax @cjihrig @BridgeAR @trivikr @codebytere @nodejs-github-bot
@posth
Copy link
Contributor

posth commented Nov 6, 2018

This PR fixes the order of the arguments of the assert.strictEqual() of test/parallel/test-http-client-upload-buf.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@posth
test: fixes order of arguments in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js
Loading status checks…
65e3106

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 6, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 6, 2018

let me know if these are coming out of NodeConfEU code & learn, so that it can be labelled appropriately, thanks!
@addaleax

addaleax approved these changes Nov 6, 2018
View changes

@addaleax addaleax added the code-and-learn label Nov 6, 2018

@BridgeAR

BridgeAR approved these changes Nov 6, 2018
View changes

@trivikr

trivikr approved these changes Nov 7, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18393/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 7, 2018 •
edited

pls thumbs up for fast tracking
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 8, 2018

one test failed in arm, but could not have caused by this change.

01:42:49 not ok 1109 parallel/test-https-host-headers
01:42:49   ---
01:42:49   duration_ms: 1.121
01:42:49   severity: fail
01:42:49   exitcode: 1
01:42:49   stack: |-
01:42:49     test https server listening on port 40551
01:42:49     /home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/parallel/test-https-host-headers.js:31
01:42:49       throw er;
01:42:49       ^
01:42:49     
01:42:49     Error: socket hang up
01:42:49         at createHangUpError (_http_client.js:330:15)
01:42:49         at TLSSocket.socketOnEnd (_http_client.js:433:23)
01:42:49         at TLSSocket.emit (events.js:187:15)
01:42:49         at endReadableNT (_stream_readable.js:1098:12)
01:42:49         at process.internalTickCallback (internal/process/next_tick.js:72:19)
01:42:49   ...
01:42:49 ok 1110 parallel/test-https-foafssl
01:42:49   ---
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 8, 2018

re-run to be absolutely sure.
new CI: https://ci.nodejs.org/job/node-test-pull-request/18411/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 9, 2018

@posth @gireeshpunathil
test: fixe argument order in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: nodejs#24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
16a199a
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 9, 2018

landed as 16a199a

thank you @posth for the contribution. Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps/

@gireeshpunathil gireeshpunathil closed this Nov 9, 2018

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@posth @amel-true
test: fixe argument order in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: nodejs#24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
b6d28e8

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@posth @rangle-tadhg
test: fixe argument order in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: nodejs#24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
7d20b83

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@posth @BridgeAR
test: fixe argument order in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: #24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
3d19a04

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@posth @kiyomizumia
test: fixe argument order in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: nodejs#24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
c987bf9

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 13, 2018

@posth @codebytere
test: fixe argument order in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: #24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d9489e1

@codebytere codebytere added the backported-to-v10.x label Dec 13, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@posth @MylesBorins
test: fixe argument order in assert.strictEqual 
File: test/parallel/test-http-client-upload-buf.js

PR-URL: #24140
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
380789e

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.