★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24134Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: swap the order of arguments #24134

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@targos targos

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@trivikr trivikr

@gdams gdams

Assignees
No one assigned
Labels
author ready backported-to-v10.x code-and-learn test
Projects
None yet
Milestone
No milestone
@mhamwala
Copy link
Contributor

mhamwala commented Nov 6, 2018 •
edited

Swapped the actual and expected arguments in assert.strictEqual() calls.
Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@mhamwala
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()` calls.
Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.
Verified
This commit was signed with a verified signature.
@mhamwala mhamwala Musa Hamwala II
GPG key ID: 0FF884D481F46463 Learn about signing commits
Loading status checks…
b6b75a5

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@targos

targos approved these changes Nov 6, 2018
View changes

@addaleax

addaleax approved these changes Nov 6, 2018
View changes

@addaleax addaleax added the code-and-learn label Nov 6, 2018

@mhamwala

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

mhamwala commented Nov 6, 2018

@jasnell lgtm
@BridgeAR

BridgeAR approved these changes Nov 6, 2018
View changes

@trivikr

trivikr approved these changes Nov 7, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 7, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18389/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 7, 2018 •
edited

pls thumbs up for fast tracking
@gdams

gdams approved these changes Nov 7, 2018
View changes

@gireeshpunathil gireeshpunathil added the author ready label Nov 8, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 8, 2018

@mhamwala @Trott
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: nodejs#24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
2535aa5
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 8, 2018

Landed in 2535aa5.

@Trott Trott closed this Nov 8, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 8, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@mhamwala @amel-true
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: nodejs#24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
e3a3efa

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@mhamwala @rangle-tadhg
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: nodejs#24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
34a2f99

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@mhamwala @BridgeAR
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: #24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
71545e6

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@mhamwala @kiyomizumia
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: nodejs#24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
7b54571

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 13, 2018

@mhamwala @codebytere
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: #24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
9dbe096

@codebytere codebytere added the backported-to-v10.x label Dec 13, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@mhamwala @MylesBorins
test: swap the order of arguments 
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: #24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
11a84a7

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.