★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24066Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix socket.connecting description #24066

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@Trott Trott

@lpinca lpinca

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
author ready doc fast-track land-on-v10.x net
Projects
None yet
Milestone
No milestone
6 participants
@addaleax @nodejs-github-bot @Trott @lpinca @joyeecheung @codebytere
@addaleax
Copy link
Member

addaleax commented Nov 3, 2018

In particular, this value is true and not false
between calling connect() and the operation finishing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@addaleax
doc: fix socket.connecting description 
In particular, this value is `true` and not `false`
between calling `connect()` and the operation finishing.
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
50a6329
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added doc net labels Nov 3, 2018

@joyeecheung

joyeecheung approved these changes Nov 3, 2018
View changes

@lpinca

lpinca approved these changes Nov 3, 2018
View changes

@Trott

Trott reviewed Nov 4, 2018
View changes

doc/api/net.md
[`socket.connect(options[, connectListener])`][`socket.connect(options)`]
was called and haven't yet finished. Will be set to `false` before emitting
was called and has not yet finished. Will be set to `true` before emitting

This comment has been minimized.

Sign in to view
Copy link
@Trott

Trott Nov 4, 2018

Member

Micro-nit: While we're in here, get rid of yet?

For some other PR perhaps: What does "finished" mean in this context? The connection has not been established? I imagine it doesn't mean that the method is still executing but that is what a naive interpretation might be....

@Trott Trott added the author ready label Nov 4, 2018

@Trott

Trott approved these changes Nov 4, 2018
View changes

@Trott Trott added the fast-track label Nov 4, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 4, 2018

Collaborators, please 👍 here to fast track.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 4, 2018

Landed in bb25457

@Trott Trott closed this Nov 4, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 4, 2018

@addaleax @Trott
doc: fix socket.connecting description 
In particular, this value is `true` and not `false`
between calling `connect()` and the operation finishing.

PR-URL: nodejs#24066
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
bb25457

targos added a commit that referenced this pull request Nov 5, 2018

@addaleax @targos
doc: fix socket.connecting description 
In particular, this value is `true` and not `false`
between calling `connect()` and the operation finishing.

PR-URL: #24066
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
94f7394

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Nov 29, 2018

@addaleax @codebytere
doc: fix socket.connecting description 
In particular, this value is `true` and not `false`
between calling `connect()` and the operation finishing.

PR-URL: #24066
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
Loading status checks…
8c9a60f

@codebytere codebytere added the land-on-v10.x label Nov 29, 2018

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@addaleax @MylesBorins
doc: fix socket.connecting description 
In particular, this value is `true` and not `false`
between calling `connect()` and the operation finishing.

PR-URL: #24066
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
40c3752

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

MylesBorins added a commit that referenced this pull request Dec 3, 2018

@addaleax @MylesBorins
doc: fix socket.connecting description 
In particular, this value is `true` and not `false`
between calling `connect()` and the operation finishing.

PR-URL: #24066
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d21a8b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.