★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23986Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-fs-watch-system-limit #23986

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@lpinca lpinca

@richardlau richardlau

@addaleax addaleax

Assignees
No one assigned
Labels
author ready dont-land-on-v8.x land-on-v10.x test
Projects
None yet
Milestone
No milestone
6 participants
@ofrobots @nodejs-github-bot @richardlau @Trott @lpinca @MylesBorins
@ofrobots
Copy link
Contributor

ofrobots commented Oct 31, 2018 •
edited

On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

CI: https://ci.nodejs.org/job/node-test-pull-request/18272/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@ofrobots
test: fix test-fs-watch-system-limit 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.
Loading status checks…
7e9be6b
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Oct 31, 2018

@ofrobots ofrobots requested a review from addaleax Oct 31, 2018

@richardlau

richardlau approved these changes Oct 31, 2018
View changes

@richardlau

This comment was marked as outdated.

Sign in to view
Copy link
Member

richardlau commented Oct 31, 2018 •
edited

Possibly applicable to other tests too: #21310

Edit: Sorry, the other issue is hitting limits (inotify limits possibly too low) which is the exact opposite of this (inotify limits too high).
@lpinca

lpinca approved these changes Oct 31, 2018
View changes

@ofrobots ofrobots added the author ready label Nov 1, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 2, 2018

@ofrobots @Trott
test: fix test-fs-watch-system-limit 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: nodejs#23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
a03165a
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 2, 2018

Landed in a03165a

@Trott Trott closed this Nov 2, 2018

targos added a commit that referenced this pull request Nov 2, 2018

@ofrobots @targos
test: fix test-fs-watch-system-limit 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
8bffd90

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

MylesBorins added a commit that referenced this pull request Nov 27, 2018

@ofrobots @MylesBorins
test: fix test-fs-watch-system-limit 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
b89297b

@MylesBorins MylesBorins added dont-land-on-v8.x land-on-v10.x labels Nov 27, 2018

@codebytere codebytere referenced this pull request Nov 27, 2018

Closed

v10.13.1 proposal #24675

rvagg added a commit that referenced this pull request Nov 28, 2018

@ofrobots @rvagg
test: fix test-fs-watch-system-limit 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
e283919

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@ofrobots @MylesBorins
test: fix test-fs-watch-system-limit 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
0ca3646

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

MylesBorins added a commit that referenced this pull request Dec 3, 2018

@ofrobots @MylesBorins
test: fix test-fs-watch-system-limit 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
5bedd1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.