★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23972Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: sort markdown refs in errors #23972

Closed
wants to merge 1 commit into from
Closed

doc: sort markdown refs in errors #23972

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Oct 30, 2018 •
edited

Checklist

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 30, 2018

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1420/pipeline

@nodejs-github-bot nodejs-github-bot added doc errors labels Oct 30, 2018
@sam-github
Copy link
Contributor Author

@sam-github sam-github commented Oct 30, 2018

ci: https://ci.nodejs.org/job/node-test-pull-request/18231/

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Oct 30, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Oct 30, 2018

Linter and linuxone CI jobs are green, so this suffices for doc changes.

@sam-github sam-github added fast-track and removed fast-track labels Oct 30, 2018
@sam-github sam-github added the fast-track label Oct 30, 2018
@sam-github
Copy link
Contributor Author

@sam-github sam-github commented Oct 30, 2018

Landed in 669c611

@sam-github sam-github closed this Oct 30, 2018
@sam-github sam-github deleted the sort-http-refs branch Oct 30, 2018
sam-github added a commit that referenced this issue Oct 30, 2018
@sam-github
doc: sort markdown refs in errors
669c611 
PR-URL: #23972
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Nov 1, 2018
@sam-github @targos
doc: sort markdown refs in errors
ee6b039 
PR-URL: #23972
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 1, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 2, 2018
Closed
@beevelop beevelop mentioned this pull request Nov 2, 2018
Closed
@beevelop beevelop mentioned this pull request Nov 2, 2018
Closed
@beevelop beevelop mentioned this pull request Nov 2, 2018
Closed
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 27, 2018

This does not land cleanly on 8.x or 10.x

Please feel free to open PRs to sort those specific lines

@sam-github sam-github mentioned this pull request Nov 27, 2018
Closed
4 tasks
sam-github added a commit to sam-github/node that referenced this issue Nov 29, 2018
@sam-github
doc: sort markdown refs in errors
4cc8ec2 
Backport-PR-URL: nodejs#24678
PR-URL: nodejs#23972
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
doc errors fast-track
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sam-github @nodejs-github-bot @vsemozhetbyt @MylesBorins @lpinca