★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23954Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix compiler warning #23954

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented Oct 29, 2018

The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@cjihrig
src: fix compiler warning 
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
ce42950
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 29, 2018

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1409/pipeline

@nodejs-github-bot nodejs-github-bot added the C++ label Oct 29, 2018

@danbev
danbev approved these changes Oct 29, 2018
View changes
@addaleax
addaleax approved these changes Oct 29, 2018
View changes
@jasnell
jasnell approved these changes Oct 29, 2018
View changes
@bnoordhuis
bnoordhuis approved these changes Oct 29, 2018
View changes
Copy link
Member

left a comment

Duplicate of #23910?


I'll get my coat.
@TimothyGu
TimothyGu approved these changes Oct 29, 2018
View changes
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 29, 2018

@bnoordhuis oops. Would you rather land 4e10934?
@bnoordhuis

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 29, 2018

Don't worry, it's fine. :-)
@refack refack referenced this pull request Oct 29, 2018
Merged
3 of 3 tasks complete
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 29, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/18214/

EDIT: Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18217/
@mmarchini
mmarchini approved these changes Oct 29, 2018
View changes

@mmarchini mmarchini added the author ready label Oct 29, 2018

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 30, 2018

Landed in 93335cb

@joyeecheung joyeecheung closed this Oct 30, 2018

joyeecheung added a commit that referenced this pull request Oct 30, 2018
@cjihrig @joyeecheung
src: fix compiler warning 
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Verified
This commit was signed with a verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
93335cb
@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 30, 2018

Landed in 93335cb

@joyeecheung Did ncu let this through? It's been open < 48 hours and wasn't fast tracked either.

(Just to be clear, I have no issue with the change itself, just the process.)
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 30, 2018

@richardlau oops, my bad, I ignored the warning because I assumed this was fast-tracked

@cjihrig cjihrig deleted the cjihrig:warning branch Oct 30, 2018

refack added a commit to refack/node that referenced this pull request Oct 31, 2018
@refack
build: add -Werror=undefined-inline to clang builds 
PR-URL: nodejs#23961
Refs: nodejs#23954
Refs: nodejs#23910
Refs: nodejs#23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Loading status checks…
c515e5c

@targos targos added the dont-land-on-v11.x label Nov 2, 2018

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 2, 2018

Depends on #23808 to land on v11.x-staging

@targos targos added this to Don't land (for now) in v11.x Nov 2, 2018

targos added a commit that referenced this pull request Nov 2, 2018
@refack @targos
build: add -Werror=undefined-inline to clang builds 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
4651cd7

@targos targos removed the dont-land-on-v11.x label Nov 18, 2018

targos added a commit that referenced this pull request Nov 18, 2018
@cjihrig @targos
src: fix compiler warning 
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
11e9d66
MylesBorins added a commit that referenced this pull request Nov 27, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
bd73da0
rvagg added a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
build: add -Werror=undefined-inline to clang builds 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
cb44bd0
rvagg added a commit that referenced this pull request Nov 28, 2018
@cjihrig @rvagg
src: fix compiler warning 
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
53fac5c
MylesBorins added a commit that referenced this pull request Nov 29, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
a1b5643
MylesBorins added a commit that referenced this pull request Dec 3, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
2e83f1e
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
Merged
4 of 4 tasks complete
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed

@codebytere codebytere added the dont-land-on-v10.x label Jan 13, 2019

@codebytere

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 13, 2019

Adding the above label as patch application reports:
No changes -- Patch already applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@danbev danbev

@jasnell jasnell

@addaleax addaleax

@TimothyGu TimothyGu

@mmarchini mmarchini

Assignees
No one assigned
Labels
C++ author ready dont-land-on-v10.x
Projects
  
Don't land (for now) in v11.x
Milestone
No milestone
You can’t perform that action at this time.