★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23927Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rename README section for Release Keys #23927

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@targos targos

@cjihrig cjihrig

@mmarchini mmarchini

@vsemozhetbyt vsemozhetbyt

@trivikr trivikr

@mihalskiy mihalskiy

Assignees
No one assigned
Labels
author ready doc dont-land-on-v8.x land-on-v10.x
Projects
None yet
Milestone
No milestone
@Trott
Copy link
Member

commented Oct 27, 2018

The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
doc: rename README section for Release Keys 
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.
Loading status checks…
9fb3ca5
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the doc label Oct 27, 2018

@vsemozhetbyt

vsemozhetbyt approved these changes Oct 27, 2018
View changes

@targos

targos approved these changes Oct 27, 2018
View changes

@lpinca

lpinca approved these changes Oct 27, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the author ready label Oct 27, 2018

@mihalskiy

mihalskiy approved these changes Oct 27, 2018
View changes

@cjihrig

cjihrig approved these changes Oct 28, 2018
View changes

@trivikr

trivikr approved these changes Oct 29, 2018
View changes

@jasnell

jasnell approved these changes Oct 29, 2018
View changes

@mmarchini

mmarchini approved these changes Oct 29, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Oct 29, 2018

Landed in d7b95f1

@Trott Trott closed this Oct 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Oct 29, 2018

@Trott
doc: rename README section for Release Keys 
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.

PR-URL: nodejs#23927
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
d7b95f1

targos added a commit that referenced this pull request Nov 1, 2018

@Trott @targos
doc: rename README section for Release Keys 
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.

PR-URL: #23927
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
8b5339d

@targos targos referenced this pull request Nov 1, 2018

Merged

Release proposal: v11.1.0 #23922

This was referenced Nov 2, 2018

Closed
Closed
Closed
Closed

MylesBorins added a commit that referenced this pull request Nov 26, 2018

@Trott @MylesBorins
doc: rename README section for Release Keys 
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.

PR-URL: #23927
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
839f026

@MylesBorins MylesBorins added dont-land-on-v8.x land-on-v10.x labels Nov 26, 2018

@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 26, 2018

I've backported to 10.x, but there is a chance this could break downstream tools that might be grepping our README to get keys. Don't think it should be an issue but want to note that this was considered when landing

@codebytere codebytere referenced this pull request Nov 27, 2018

Closed

v10.13.1 proposal #24675

rvagg added a commit that referenced this pull request Nov 28, 2018

@Trott @rvagg
doc: rename README section for Release Keys 
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.

PR-URL: #23927
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
0ed7da8

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@Trott @MylesBorins
doc: rename README section for Release Keys 
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.

PR-URL: #23927
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
96004d6

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.