★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23829Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix strictEqual() argument order #23829

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@targos targos

@cjihrig cjihrig

@trivikr trivikr

Assignees
No one assigned
Labels
author ready land-on-v10.x land-on-v8.x test
Projects
None yet
Milestone
No milestone
10 participants
@lveteau @Trott @danbev @jasnell @lpinca @targos @cjihrig @trivikr @MylesBorins @nodejs-github-bot
@lveteau
Copy link
Contributor

lveteau commented Oct 23, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Oct 23, 2018

@cjihrig

cjihrig approved these changes Oct 23, 2018
View changes

@targos

targos approved these changes Oct 23, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Oct 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18081/

@Trott Trott added the author ready label Oct 23, 2018

@lpinca

lpinca approved these changes Oct 23, 2018
View changes

@jasnell

jasnell approved these changes Oct 23, 2018
View changes

@trivikr

trivikr approved these changes Oct 24, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Oct 26, 2018

Landed in 817e2e8. 🎉 Thanks!

@danbev danbev closed this Oct 26, 2018

danbev added a commit that referenced this pull request Oct 26, 2018

@lveteau @danbev
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Loading status checks…
817e2e8

targos added a commit that referenced this pull request Oct 26, 2018

@lveteau @targos
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
3b52343

@targos targos referenced this pull request Oct 27, 2018

Merged

Release proposal: v11.1.0 #23922

targos added a commit that referenced this pull request Nov 1, 2018

@lveteau @targos
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
22caa26

This was referenced Nov 2, 2018

Closed
Closed
Closed
Closed

MylesBorins added a commit that referenced this pull request Nov 26, 2018

@lveteau @MylesBorins
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
1c6820b

MylesBorins added a commit that referenced this pull request Nov 26, 2018

@lveteau @MylesBorins
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
27dad96

@MylesBorins MylesBorins added land-on-v8.x land-on-v10.x labels Nov 26, 2018

@codebytere codebytere referenced this pull request Nov 27, 2018

Closed

v10.13.1 proposal #24675

rvagg added a commit that referenced this pull request Nov 28, 2018

@lveteau @rvagg
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
d0368b8

rvagg added a commit that referenced this pull request Nov 28, 2018

@lveteau @rvagg
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
7e98bc6

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@lveteau @MylesBorins
test: fix strictEqual() argument order 
PR-URL: #23829
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
682361c

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

@BethGriggs BethGriggs referenced this pull request Dec 4, 2018

Merged

v8.14.1 proposal #24832

This was referenced Dec 18, 2018

Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.