★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23782Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: simplify `TimerFunctionCall()` in `node_perf.cc` #23782

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@refack refack

@bnoordhuis bnoordhuis

@jasnell jasnell

@cjihrig cjihrig

@mmarchini mmarchini

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
C++ author ready backported-to-v10.x
Projects
None yet
Milestone
No milestone
@addaleax
Copy link
Member

addaleax commented Oct 20, 2018

Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary TryCatch.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
src: simplify `TimerFunctionCall()` in `node_perf.cc` 
Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary `TryCatch`.
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
10eeec8
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the C++ label Oct 20, 2018

@refack

refack approved these changes Oct 20, 2018
View changes

Copy link
Member

refack left a comment

👍 👍
Show resolved Hide resolved src/node_perf.cc
Show resolved Hide resolved src/node_perf.cc
@cjihrig

cjihrig approved these changes Oct 22, 2018
View changes

@joyeecheung

joyeecheung approved these changes Oct 23, 2018
View changes

@mmarchini

mmarchini approved these changes Oct 23, 2018
View changes

@mmarchini mmarchini added the author ready label Oct 23, 2018

@mmarchini

This comment has been minimized.

Sign in to view
Copy link
Member

mmarchini commented Oct 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18075/
@bnoordhuis

bnoordhuis approved these changes Oct 23, 2018
View changes

Show resolved Hide resolved src/node_perf.cc
@jasnell

jasnell approved these changes Oct 23, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Oct 24, 2018

Landed in 22ee5d9.

@danbev danbev closed this Oct 24, 2018

danbev added a commit that referenced this pull request Oct 24, 2018

@addaleax @danbev
src: simplify `TimerFunctionCall()` in `node_perf.cc` 
Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary `TryCatch`.

PR-URL: #23782
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
22ee5d9

@addaleax addaleax deleted the addaleax:perf-simplify-timer-fn-call branch Oct 24, 2018

targos added a commit that referenced this pull request Oct 24, 2018

@addaleax @targos
src: simplify `TimerFunctionCall()` in `node_perf.cc` 
Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary `TryCatch`.

PR-URL: #23782
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a6fe2ca

@targos targos referenced this pull request Oct 27, 2018

Merged

Release proposal: v11.1.0 #23922

This was referenced Nov 2, 2018

Closed
Closed
Closed
Closed
@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

MylesBorins commented Nov 26, 2018

Should this be backported to LTS?

It lands cleanly on 10.x but would require a manual backport for 8.x

@MylesBorins MylesBorins added lts-watch-v8.x lts-watch-v10.x labels Nov 26, 2018

@codebytere codebytere removed the lts-watch-v8.x label Dec 13, 2018

codebytere added a commit that referenced this pull request Dec 13, 2018

@addaleax @codebytere
src: simplify `TimerFunctionCall()` in `node_perf.cc` 
Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary `TryCatch`.

PR-URL: #23782
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
e8200c0

@codebytere codebytere added backported-to-v10.x and removed lts-watch-v10.x labels Dec 13, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@addaleax @MylesBorins
src: simplify `TimerFunctionCall()` in `node_perf.cc` 
Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary `TryCatch`.

PR-URL: #23782
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
15d05bb

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.