★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23771Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix strictEqual() arguments order #23771

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@targos targos

@cjihrig cjihrig

@trivikr trivikr

Assignees
No one assigned
Labels
author ready land-on-v10.x land-on-v8.x test
Projects
None yet
Milestone
No milestone
8 participants
@fraxken @trivikr @danbev @jasnell @targos @cjihrig @MylesBorins @nodejs-github-bot
@fraxken
Copy link
Contributor

fraxken commented Oct 19, 2018

Thanks to @targos for the opportunity to create this pull-request.

Note: core-validate-commit return K.O on PR-URL and must have one reviewer (I did not know how to solve these two).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the test label Oct 19, 2018

@jasnell

jasnell approved these changes Oct 19, 2018
View changes

@trivikr

trivikr approved these changes Oct 19, 2018
View changes

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Oct 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17995/

@trivikr trivikr added the author ready label Oct 19, 2018

@targos

targos approved these changes Oct 20, 2018
View changes

@cjihrig

cjihrig approved these changes Oct 20, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Oct 23, 2018

Landed in a1ee86c. 🎉 Thanks!

@danbev danbev closed this Oct 23, 2018

danbev added a commit that referenced this pull request Oct 23, 2018

@fraxken @danbev
test: fix strictEqual() arguments order 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Loading status checks…
a1ee86c

targos added a commit that referenced this pull request Oct 24, 2018

@fraxken @targos
test: fix strictEqual() arguments order 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a666d3e

@targos targos referenced this pull request Oct 27, 2018

Merged

Release proposal: v11.1.0 #23922

This was referenced Nov 2, 2018

Closed
Closed
Closed
Closed

MylesBorins added a commit that referenced this pull request Nov 26, 2018

@fraxken @MylesBorins
test: fix strictEqual() arguments order 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
c5d74be

MylesBorins added a commit that referenced this pull request Nov 26, 2018

@fraxken @MylesBorins
test: fix strictEqual() arguments order 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
6ee9273

@MylesBorins MylesBorins added land-on-v8.x land-on-v10.x labels Nov 26, 2018

@codebytere codebytere referenced this pull request Nov 27, 2018

Closed

v10.13.1 proposal #24675

rvagg added a commit that referenced this pull request Nov 28, 2018

@fraxken @rvagg
test: fix strictEqual() arguments order 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
0f98c49

rvagg added a commit that referenced this pull request Nov 28, 2018

@fraxken @rvagg
test: fix strictEqual() arguments order 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
daa17ed

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@fraxken @MylesBorins
test: fix strictEqual() arguments order 
PR-URL: #23771
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
3d43679

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

@BethGriggs BethGriggs referenced this pull request Dec 4, 2018

Merged

v8.14.1 proposal #24832

This was referenced Dec 18, 2018

Closed
Closed
Closed

This was referenced Dec 18, 2018

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.