★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23707Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use Cookie in request.setHeader() examples #23707

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@cjihrig cjihrig

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
doc dont-land-on-v8.x http land-on-v10.x
Projects
None yet
Milestone
No milestone
7 participants
@lpinca @nodejs-github-bot @addaleax @jasnell @cjihrig @vsemozhetbyt @MylesBorins
@lpinca
Copy link
Member

lpinca commented Oct 17, 2018

Set-Cookie is a response header, replace it with Cookie.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@lpinca
doc: use Cookie in request.setHeader() examples 
`Set-Cookie` is a response header, replace it with `Cookie`.
Loading status checks…
764bfd7
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added doc http labels Oct 17, 2018

@cjihrig

cjihrig approved these changes Oct 17, 2018
View changes

@vsemozhetbyt

vsemozhetbyt approved these changes Oct 17, 2018
View changes

@jasnell

jasnell approved these changes Oct 17, 2018
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Oct 24, 2018

Landed in 862b7a1

@addaleax addaleax closed this Oct 24, 2018

addaleax added a commit that referenced this pull request Oct 24, 2018

@lpinca @addaleax
doc: use Cookie in request.setHeader() examples 
`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
862b7a1

@lpinca lpinca deleted the lpinca:replace/set-cookie-with-cookie branch Oct 24, 2018

targos added a commit that referenced this pull request Oct 24, 2018

@lpinca @targos
doc: use Cookie in request.setHeader() examples 
`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
d808d27

@targos targos referenced this pull request Oct 27, 2018

Merged

Release proposal: v11.1.0 #23922

This was referenced Nov 2, 2018

Closed
Closed
Closed
Closed

@MylesBorins MylesBorins added dont-land-on-v8.x land-on-v10.x labels Nov 26, 2018

MylesBorins added a commit that referenced this pull request Nov 26, 2018

@lpinca @MylesBorins
doc: use Cookie in request.setHeader() examples 
`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
8a6086c

@codebytere codebytere referenced this pull request Nov 27, 2018

Closed

v10.13.1 proposal #24675

rvagg added a commit that referenced this pull request Nov 28, 2018

@lpinca @rvagg
doc: use Cookie in request.setHeader() examples 
`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
1589cb7

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@lpinca @MylesBorins
doc: use Cookie in request.setHeader() examples 
`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
1921865

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.