★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23432Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Ruben Bridgewater to release team #23432

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@MylesBorins MylesBorins

@evanlucas evanlucas

@thefourtheye thefourtheye

@addaleax addaleax

@targos targos

@cjihrig cjihrig

@richardlau richardlau

@gireeshpunathil gireeshpunathil

@mhdawson mhdawson

Assignees
No one assigned
Labels
doc meta
Projects
None yet
Milestone
No milestone
@BridgeAR
Copy link
Member

BridgeAR commented Oct 11, 2018

/cc @nodejs/release @nodejs/tsc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the doc label Oct 11, 2018

@targos

targos approved these changes Oct 11, 2018
View changes

@richardlau

richardlau approved these changes Oct 11, 2018
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Oct 11, 2018

@nodejs/build-infra Ruben needs his ssh keys added to the dist user on the website host.
@gireeshpunathil

gireeshpunathil approved these changes Oct 11, 2018
View changes

@thefourtheye

thefourtheye approved these changes Oct 11, 2018
View changes

@jasnell

jasnell approved these changes Oct 12, 2018
View changes

@evanlucas

evanlucas approved these changes Oct 12, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the meta label Oct 12, 2018

@MylesBorins

MylesBorins requested changes Oct 15, 2018
View changes

Copy link
Member

MylesBorins left a comment

Based on the current governance of the Release team this should not land until Ruben has prepared 3 Current releases.

If we are concerned that the timeline for this is too long we can revisit those rules over in the Release repo
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 20, 2018

Ruben prepared the release of v11.2.0 last week. Per the new governance, he shall be considered a full member of the releasers team now. @MylesBorins can we proceed with this PR?
@MylesBorins

MylesBorins approved these changes Nov 20, 2018
View changes

Copy link
Member

MylesBorins left a comment

LGTM
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 20, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1657/
@mhdawson

mhdawson approved these changes Nov 20, 2018
View changes

Copy link
Member

mhdawson left a comment

LGTM
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 20, 2018

@BridgeAR could you rebase on master? I tried to set the option in the CI job but it failed.
@cjihrig

cjihrig approved these changes Nov 20, 2018
View changes

@addaleax

addaleax approved these changes Nov 20, 2018
View changes

@BridgeAR
doc: add Ruben Bridgewater to release team
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
ad4890c

@BridgeAR BridgeAR force-pushed the BridgeAR:add-myself-to-release-team branch from 5b3af3d to ad4890c Nov 21, 2018

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

BridgeAR commented Nov 21, 2018

@targos done

CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1663/
@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

MylesBorins commented Nov 21, 2018

Welcome to the team!

landed in 9379ab3

@MylesBorins MylesBorins closed this Nov 21, 2018

MylesBorins added a commit that referenced this pull request Nov 21, 2018

@BridgeAR @MylesBorins
doc: add Ruben Bridgewater to release team 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
9379ab3

This was referenced Nov 21, 2018

Merged
Closed

targos added a commit that referenced this pull request Nov 21, 2018

@BridgeAR @targos
doc: add Ruben Bridgewater to release team 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
5101ab8

rvagg added a commit that referenced this pull request Nov 28, 2018

@BridgeAR @rvagg
doc: add Ruben Bridgewater to release team 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
1a74fad

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

@beevelop beevelop referenced this pull request Dec 7, 2018

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR #261

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@BridgeAR @codebytere
doc: add Ruben Bridgewater to release team 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
Loading status checks…
b0d265c

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@BridgeAR @refack
doc: add Ruben Bridgewater to release team 
PR-URL: nodejs#23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
7ab43c5

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@BridgeAR @MylesBorins
doc: add Ruben Bridgewater to release team 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
85798fc

codebytere added a commit that referenced this pull request Jan 29, 2019

@BridgeAR @codebytere
doc: add Ruben Bridgewater to release team 
PR-URL: #23432
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
f0602f8

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.