★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23199Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove some useless assignments #23199

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@mscdex mscdex

@indutny indutny

@thefourtheye thefourtheye

@addaleax addaleax

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
events net readline
Projects
None yet
Milestone
No milestone
10 participants
@devsnek @nodejs-github-bot @addaleax @danbev @Trott @mscdex @indutny @thefourtheye @cjihrig @BridgeAR
@devsnek
Copy link
Member

devsnek commented Oct 1, 2018

cc @indutny

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@devsnek
lib: remove some useless assignments
Verified
This commit was signed with a verified signature.
@devsnek devsnek Gus Caplan
GPG key ID: F00BD11880E82F0E Learn about signing commits
Loading status checks…
364e330
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added events net readline labels Oct 1, 2018

@addaleax

addaleax approved these changes Oct 1, 2018
View changes

@cjihrig

cjihrig approved these changes Oct 1, 2018
View changes

@BridgeAR

BridgeAR approved these changes Oct 1, 2018
View changes

@mscdex

mscdex reviewed Oct 1, 2018
View changes

lib/net.js
@@ -1081,10 +1081,6 @@ function afterConnect(status, handle, req, readable, writable) {
return;
}

// Update handle if it was wrapped
// TODO(indutny): assert that the handle is actually an ancestor of old one

This comment has been minimized.

Sign in to view
Copy link
@mscdex

mscdex Oct 1, 2018

Contributor

Should this TODO be removed?

This comment has been minimized.

Sign in to view
Copy link
@devsnek

devsnek Oct 1, 2018

Author Member

that's why I pinged @indutny

This comment has been minimized.

Sign in to view
Copy link
@indutny

indutny Oct 11, 2018

Member

I'm afraid I no longer remember what this was about. This comments is years old.

This comment has been minimized.

Sign in to view
Copy link
@thefourtheye

thefourtheye Oct 11, 2018

Contributor

Perhaps this particular change alone can be done in a separate PR then?
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Oct 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17639/

@addaleax addaleax added the author ready label Oct 4, 2018

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Oct 5, 2018 •
edited

Re-run of failing node-test-commit-arm ✔️

@devsnek devsnek removed the author ready label Oct 5, 2018

@devsnek

This comment has been minimized.

Sign in to view
Copy link
Member Author

devsnek commented Oct 5, 2018

this can't land until @indutny confirms the removal of that line
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 5, 2018

Given that @indutny isn't sure what the line refers to, I think it's acceptable to remove it as no one else is likely to know either.

Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018

@devsnek @Trott
lib: remove some useless assignments 
PR-URL: nodejs#23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
366aaf5
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 5, 2018

Landed in 366aaf5

@Trott Trott closed this Dec 5, 2018

BridgeAR added a commit that referenced this pull request Dec 6, 2018

@devsnek @BridgeAR
lib: remove some useless assignments 
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
fb2c9ee

@BridgeAR BridgeAR referenced this pull request Dec 6, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

BridgeAR added a commit that referenced this pull request Dec 7, 2018

@devsnek @BridgeAR
lib: remove some useless assignments 
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
6c8a73d

BridgeAR added a commit that referenced this pull request Dec 7, 2018

@devsnek @BridgeAR
lib: remove some useless assignments 
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
eec87fa

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@devsnek @refack
lib: remove some useless assignments 
PR-URL: nodejs#23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
461e7b9

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@devsnek @BethGriggs
lib: remove some useless assignments 
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
d5d8670

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

BethGriggs added a commit that referenced this pull request Feb 20, 2019

@devsnek @BethGriggs
lib: remove some useless assignments 
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
66bad4f

rvagg added a commit that referenced this pull request Feb 28, 2019

@devsnek @rvagg
lib: remove some useless assignments 
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
9197b50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.