★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23182Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,deps: refactor and fix v8.gyp #23182

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@targos targos

@cjihrig cjihrig

Assignees
No one assigned
Labels
V8 Engine build post-mortem
Projects
None yet
Milestone
No milestone
4 participants
@refack @nodejs-github-bot @targos @jasnell
@refack
Copy link
Member

refack commented Sep 30, 2018

  • Make inspector.gypi and v8_external_snapshot.gypi includible targets.
  • Make v8_dump_build_config an action
  • Better separate js2c and natives_blob
  • process action outputs as sources
  • trigger v8.gyp:postmortem-metadata from v8.gyp

Refs: #23156

/CC @nodejs/build-files @nodejs/gyp

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@refack
build,deps: refactor and fix v8.gyp 
* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp
Loading status checks…
5719289

@refack refack requested a review from targos Sep 30, 2018

@nodejs-github-bot

@refack refack requested a review from cjihrig Sep 30, 2018

@nodejs-github-bot nodejs-github-bot added build V8 Engine labels Sep 30, 2018

@refack refack self-assigned this Sep 30, 2018

@refack refack added the post-mortem label Sep 30, 2018

@refack refack referenced this pull request Sep 30, 2018

Merged

Build and gyp fixes #23156

3 of 3 tasks complete
@jasnell

jasnell approved these changes Oct 1, 2018
View changes

@refack refack referenced this pull request Oct 3, 2018

Open

Missing out/Debug/node on test-digitalocean-ubuntu1604_sharedlibs_container-x64-* #1516

@targos targos referenced this pull request Oct 4, 2018

Closed

make with -j hangs #23255

@targos

targos approved these changes Oct 4, 2018
View changes

@targos
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Oct 4, 2018

The embedder string should be incremented (can be done while landing)

targos added a commit to targos/node that referenced this pull request Oct 4, 2018

@refack @targos
build,deps: refactor and fix v8.gyp 
* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp

PR-URL: nodejs#23182
Refs: nodejs#23156
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
9800fd7
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Oct 4, 2018

Landed in 9800fd7

@targos targos closed this Oct 4, 2018

@refack refack deleted the refack:v8-gyp-cleanup branch Oct 4, 2018

targos added a commit that referenced this pull request Oct 5, 2018

@refack @targos
build,deps: refactor and fix v8.gyp 
* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp

PR-URL: #23182
Refs: #23156
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
2b8f569

@targos targos referenced this pull request Oct 7, 2018

Merged

Release proposal: v10.12.0 #23313

This was referenced Oct 10, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

@beevelop beevelop referenced this pull request Oct 11, 2018

Closed

2018-10-10 Version 10.12.0 (Current) @targos #229

@refack refack restored the refack:v8-gyp-cleanup branch Oct 12, 2018

@refack refack deleted the refack:v8-gyp-cleanup branch Oct 12, 2018

@refack refack removed their assignment Oct 12, 2018

jasnell added a commit that referenced this pull request Oct 17, 2018

@refack @jasnell
build,deps: refactor and fix v8.gyp 
* Make inspector.gypi and v8_external_snapshot.gypi includible targets.
* Make `v8_dump_build_config` an action
* Better separate `js2c` and `natives_blob`
* process action outputs as sources
* trigger v8.gyp:postmortem-metadata from v8.gyp

PR-URL: #23182
Refs: #23156
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@jasnell jasnell James M Snell
GPG key ID: 7341B15C070877AC Learn about signing commits
87d801c

This was referenced Oct 21, 2018

Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.