★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22749Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make doc generation work on Windows #22749

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@refack refack

@jasnell jasnell

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
build fast-track windows
Projects
None yet
Milestone
No milestone
6 participants
@tniessen @nodejs-github-bot @refack @jasnell @richardlau @BridgeAR
@tniessen
Copy link
Member

tniessen commented Sep 7, 2018

#21697 broke doc generation on Windows since the option name for the output directory was incorrect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@tniessen
build: make doc generation work on Windows 
Refs: #21697
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
3f0e696

@nodejs-github-bot nodejs-github-bot added build windows labels Sep 7, 2018

@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Sep 7, 2018

Please 👍 here to approve fast-tracking.
@nodejs-github-bot
@richardlau

richardlau approved these changes Sep 7, 2018
View changes

@refack

refack approved these changes Sep 7, 2018
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Sep 7, 2018

/CC @nodejs/platform-windows @nodejs/build-files
@BridgeAR

BridgeAR approved these changes Sep 7, 2018
View changes

@jasnell

jasnell approved these changes Sep 7, 2018
View changes

@tniessen tniessen added the fast-track label Sep 8, 2018

@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Sep 8, 2018

Landed in 3f67190.

@tniessen tniessen closed this Sep 8, 2018

tniessen added a commit to tniessen/node that referenced this pull request Sep 8, 2018

@tniessen
build: make doc generation work on Windows 
PR-URL: nodejs#22749
Refs: nodejs#21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
3f67190

targos added a commit that referenced this pull request Sep 9, 2018

@tniessen @targos
build: make doc generation work on Windows 
PR-URL: #22749
Refs: #21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a78a946

@targos targos referenced this pull request Sep 18, 2018

Merged

Release proposal: v10.11.0 #22932

BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 2, 2018

@tniessen @BridgeAR
build: make doc generation work on Windows 
PR-URL: nodejs#22749
Refs: nodejs#21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
d401b35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.