★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22309Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document 'inherit' option for stdio (non-shorthand) #22309

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@benjamingr benjamingr

@gireeshpunathil gireeshpunathil

@vsemozhetbyt vsemozhetbyt

@trivikr trivikr

Assignees
No one assigned
Labels
author ready child_process doc fast-track
Projects
None yet
Milestone
No milestone
6 participants
@thw0rted @gireeshpunathil @vsemozhetbyt @benjamingr @trivikr @nodejs-github-bot
@thw0rted
Copy link
Contributor

thw0rted commented Aug 14, 2018

Fixes: #22297

Checklist

@nodejs-github-bot nodejs-github-bot added child_process doc labels Aug 14, 2018

@gireeshpunathil

gireeshpunathil approved these changes Aug 14, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Aug 14, 2018

/cc @vsemozhetbyt @nodejs/child_process @nodejs/documentation
@vsemozhetbyt

vsemozhetbyt approved these changes Aug 14, 2018
View changes

Copy link
Member

vsemozhetbyt left a comment

Doc format LGTM.
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Aug 14, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/557/
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Aug 14, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@benjamingr

benjamingr approved these changes Aug 14, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the author ready label Aug 14, 2018

@trivikr

trivikr approved these changes Aug 14, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the fast-track label Aug 14, 2018

vsemozhetbyt added a commit that referenced this pull request Aug 14, 2018

@thw0rted @vsemozhetbyt
doc: document 'inherit' option for stdio (non-shorthand) 
PR-URL: #22309
Fixes: #22297
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Loading status checks…
dccec3f
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Aug 14, 2018

Landed in dccec3f
Thank you!

@vsemozhetbyt vsemozhetbyt closed this Aug 14, 2018

rvagg added a commit that referenced this pull request Aug 15, 2018

@thw0rted @rvagg
doc: document 'inherit' option for stdio (non-shorthand) 
PR-URL: #22309
Fixes: #22297
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
8f79a90

@rvagg rvagg referenced this pull request Aug 15, 2018

Merged

Release proposal: v10.9.0 #22295

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.