★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22307Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename some disturbing allegories #22307

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@refack refack

@danbev danbev

@addaleax addaleax

@benjamingr benjamingr

@cjihrig cjihrig

@maclover7 maclover7

Assignees
No one assigned
Labels
author ready fast-track test
Projects
None yet
Milestone
No milestone
8 participants
@vsemozhetbyt @nodejs-github-bot @refack @danbev @addaleax @benjamingr @cjihrig @maclover7
@vsemozhetbyt
Copy link
Member

vsemozhetbyt commented Aug 14, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This somehow hit me in #22303, so I thought we could do the same we had done for the child_process doc. I've renamed only some cases where renaming impact was not so big.
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Aug 14, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Aug 14, 2018 •
edited

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16435/
@danbev

danbev approved these changes Aug 14, 2018
View changes

@addaleax

addaleax approved these changes Aug 14, 2018
View changes

Copy link
Member

addaleax left a comment

Thank you! 💙
@cjihrig

cjihrig approved these changes Aug 14, 2018
View changes

@maclover7

maclover7 approved these changes Aug 14, 2018
View changes

@vsemozhetbyt
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Aug 14, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@benjamingr

benjamingr approved these changes Aug 14, 2018
View changes

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Aug 14, 2018

Concerning repeated fails: #22308
@refack

refack approved these changes Aug 14, 2018
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Aug 14, 2018

Rest of fails are git related - nodejs/reliability#12 (comment)
So IMHO this is ready to land

@refack refack added the author ready label Aug 14, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Aug 14, 2018

@vsemozhetbyt I would rename the commit to something more generic, like
test: rename allegories, just to reduce curiosity.

@vsemozhetbyt vsemozhetbyt added the fast-track label Aug 14, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Aug 14, 2018

Landed in 682f9b4 with more generic commit name.
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt closed this Aug 14, 2018

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:rename-disturbing branch Aug 14, 2018

vsemozhetbyt added a commit that referenced this pull request Aug 14, 2018

@vsemozhetbyt
test: rename some allegories 
PR-URL: #22307
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Loading status checks…
682f9b4

rvagg added a commit that referenced this pull request Aug 15, 2018

@vsemozhetbyt @rvagg
test: rename some allegories 
PR-URL: #22307
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
65d1e02

@rvagg rvagg referenced this pull request Aug 15, 2018

Merged

Release proposal: v10.9.0 #22295

@joyeecheung joyeecheung referenced this pull request Aug 15, 2018

Closed

CI failures: 20180815 #13

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.