doc: discuss special protocol handling #22261
Conversation
|
Please |
Left some non-blocking nits.
doc/api/url.md
Outdated
| ##### Special Schemes | ||
|
|
||
| The WHATWG URL Standard considers a handful of URL protocol schemes to be | ||
| "special" in terms of how those are parsed and serialized. When a URL is |
- Italics instead of quotes around
special. those->they
doc/api/url.md
Outdated
| ``` | ||
|
|
||
| However, changing from `http` to a hypothetical `fish` protocol does not | ||
| because the new protocol is not considered "special". |
- No quotes around
special.
doc/api/url.md
Outdated
| @@ -389,6 +389,46 @@ console.log(myURL.href); | |||
|
|
|||
| Invalid URL protocol values assigned to the `protocol` property are ignored. | |||
|
|
|||
| ##### Special Schemes | |||
|
|
|||
| The WHATWG URL Standard considers a handful of URL protocol schemes to be | |||
Linking the text WHATWG URL Standard to the standard itself would be useful here. It's already linked in two other places in the doc, so it's just a matter of changing the markdown to [WHATWG URL Standard][].
|
(Intentionally not approving fast-tracking here. There's enough new material here that it's probably worth not rushing the review process IMO and I'm unaware of any reason to rush landing it. I won't block fast-tracking but I'd ask people to consider carefully if this really needs to be fast-tracked.) |
|
@jasnell You added the |
|
Feel free to push your suggested edits to the PR. |
|
|
Landed in 58cf409 (fast tracked with approval) |
|
^ Accidental tag removal and addition. Sorry! |
Fixes: #13523
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe text was updated successfully, but these errors were encountered: