★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22254Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-http2-large-file sequential test #22254

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@mcollina mcollina

@addaleax addaleax

@lpinca lpinca

@trivikr trivikr

@gdams gdams

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
7 participants
@jasnell @nodejs-github-bot @gdams @mcollina @addaleax @lpinca @trivikr
@jasnell
Copy link
Member

jasnell commented Aug 10, 2018

Refs: #19141

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Aug 10, 2018

@jasnell jasnell requested a review from mcollina Aug 10, 2018

@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member Author

jasnell commented Aug 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16353/
@addaleax

addaleax approved these changes Aug 10, 2018
View changes

@jasnell jasnell added the author ready label Aug 11, 2018

@mcollina

mcollina approved these changes Aug 11, 2018
View changes

Copy link
Member

mcollina left a comment

LGTM
@trivikr

trivikr approved these changes Aug 12, 2018
View changes

@gdams

gdams approved these changes Aug 12, 2018
View changes

@lpinca

lpinca approved these changes Aug 12, 2018
View changes

@gdams

This comment has been minimized.

Sign in to view
Copy link
Member

gdams commented Aug 13, 2018

landed in: c29aff3

@gdams gdams closed this Aug 13, 2018

gdams pushed a commit that referenced this pull request Aug 13, 2018

@jasnell George Adams
test: add test-http2-large-file sequential test 
Refs: #19141

PR-URL: #22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
c29aff3

rvagg added a commit that referenced this pull request Aug 15, 2018

@jasnell @rvagg
test: add test-http2-large-file sequential test 
Refs: #19141

PR-URL: #22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
dc57d4e

@rvagg rvagg referenced this pull request Aug 15, 2018

Merged

Release proposal: v10.9.0 #22295

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

@TimothyGu TimothyGu referenced this pull request Aug 18, 2018

Closed

Post large file failed when the initialWindowSize of HTTP2 Settings Object set to 6553500 #19141

kjin added a commit to kjin/node that referenced this pull request Sep 17, 2018

@jasnell @kjin
test: add test-http2-large-file sequential test 
Refs: nodejs#19141

PR-URL: nodejs#22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
0dfa1e4

kjin added a commit to kjin/node that referenced this pull request Sep 19, 2018

@jasnell @kjin
test: add test-http2-large-file sequential test 
Refs: nodejs#19141

PR-URL: nodejs#22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
4c1b341

kjin added a commit to kjin/node that referenced this pull request Sep 25, 2018

@jasnell @kjin
test: add test-http2-large-file sequential test 
Refs: nodejs#19141

PR-URL: nodejs#22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
7574071

kjin added a commit to kjin/node that referenced this pull request Oct 16, 2018

@jasnell @kjin
test: add test-http2-large-file sequential test 
Refs: nodejs#19141

PR-URL: nodejs#22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
81f3ebc

BethGriggs added a commit to BethGriggs/node that referenced this pull request Oct 16, 2018

@jasnell @BethGriggs
test: add test-http2-large-file sequential test 
Refs: nodejs#19141

Backport-PR-URL: nodejs#22850
PR-URL: nodejs#22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
b4e004c

BethGriggs added a commit that referenced this pull request Oct 17, 2018

@jasnell @BethGriggs
test: add test-http2-large-file sequential test 
Refs: #19141

Backport-PR-URL: #22850
PR-URL: #22254
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
b66cba0

@BethGriggs BethGriggs referenced this pull request Oct 30, 2018

Merged

v8.13.0 proposal #23974

@beevelop beevelop referenced this pull request Nov 20, 2018

Closed

2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.