★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22243Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util,assert: fix boxed primitives bug #22243

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@lpinca lpinca

@trivikr trivikr

@gdams gdams

Assignees
No one assigned
Labels
author ready util
Projects
None yet
Milestone
No milestone
5 participants
@BridgeAR @nodejs-github-bot @lpinca @trivikr @gdams
@BridgeAR
Copy link
Member

BridgeAR commented Aug 10, 2018

Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@BridgeAR
util,assert: fix boxed primitives bug 
Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
1961097
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the util label Aug 10, 2018

@lpinca

lpinca approved these changes Aug 10, 2018
View changes

@lpinca

This comment has been minimized.

Sign in to view
Copy link
Member

lpinca commented Aug 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16349/

@BridgeAR BridgeAR added the author ready label Aug 10, 2018

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Aug 12, 2018

Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16379/
@trivikr

trivikr approved these changes Aug 12, 2018
View changes

@gdams

gdams approved these changes Aug 12, 2018
View changes

@gdams

This comment has been minimized.

Sign in to view
Copy link
Member

gdams commented Aug 12, 2018 •
edited

landed in: c7ca199

@gdams gdams closed this Aug 12, 2018

gdams pushed a commit that referenced this pull request Aug 12, 2018

@BridgeAR George Adams
util,assert: fix boxed primitives bug 
Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.

PR-URL: #22243
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
c7ca199

rvagg added a commit that referenced this pull request Aug 13, 2018

@BridgeAR @rvagg
util,assert: fix boxed primitives bug 
Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.

PR-URL: #22243
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
c3365db

@rvagg rvagg referenced this pull request Aug 13, 2018

Merged

Release proposal: v10.9.0 #22295

rvagg added a commit that referenced this pull request Aug 13, 2018

@BridgeAR @rvagg
util,assert: fix boxed primitives bug 
Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.

PR-URL: #22243
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
41b5172

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.