★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22242Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: tie objects lifetime to the thread they belong to #22242

Merged
merged 0 commits into from Aug 14, 2018

Conversation

Reviewers

@ak239 ak239

@jasnell jasnell

Assignees
No one assigned
Labels
C++ author ready
Projects
None yet
Milestone
No milestone
5 participants
@eugeneo @nodejs-github-bot @trivikr @ak239 @jasnell
@eugeneo
Copy link
Contributor

eugeneo commented Aug 10, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This is needed for #21364
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the C++ label Aug 10, 2018

@jasnell

jasnell approved these changes Aug 10, 2018
View changes

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Aug 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16380/

@trivikr trivikr added the author ready label Aug 12, 2018

@eugeneo eugeneo force-pushed the eugeneo:objects_live_in_thread branch from 7e3df46 to 3ba44db Aug 13, 2018

@eugeneo

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

eugeneo commented Aug 13, 2018

Fixed Visual C++ compilation.

CI: https://ci.nodejs.org/job/node-test-pull-request/16424/
@ak239

ak239 approved these changes Aug 13, 2018
View changes

@eugeneo

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

eugeneo commented Aug 13, 2018

Windows CI failure is #21425
LinuxOne is an infrastructure issue.

@eugeneo eugeneo closed this Aug 14, 2018

@eugeneo eugeneo force-pushed the eugeneo:objects_live_in_thread branch from 3ba44db to 7404a4d Aug 14, 2018

@eugeneo eugeneo deleted the eugeneo:objects_live_in_thread branch Aug 14, 2018

@eugeneo

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

eugeneo commented Aug 14, 2018

Landed as eugeneo@7404a4d

@eugeneo eugeneo merged commit 7404a4d into nodejs:master Aug 14, 2018

rvagg added a commit that referenced this pull request Aug 15, 2018

@eugeneo @rvagg
inspector: tie objects lifetime to the thread they belong to 
PR-URL: #22242
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
b97c73f

@rvagg rvagg referenced this pull request Aug 15, 2018

Merged

Release proposal: v10.9.0 #22295

@joyeecheung joyeecheung referenced this pull request Aug 15, 2018

Closed

CI failures: 20180815 #13

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.