doc: add gdams to collaborators #22236
Closed
Conversation
addaleax
approved these changes
Aug 10, 2018
I think you want a space after the email address :)
richardlau
approved these changes
Aug 10, 2018
refack
approved these changes
Aug 10, 2018
mhdawson
approved these changes
Aug 10, 2018
LGTM, welcome :)
|
New CI run after addressing changes: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/492/ |
jasnell
approved these changes
Aug 10, 2018
vsemozhetbyt
approved these changes
Aug 10, 2018
Trott
approved these changes
Aug 10, 2018
|
landed as: 91e897a |
gdams
pushed a commit
that referenced
this issue
Aug 10, 2018
PR-URL: #22236 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
added a commit
that referenced
this issue
Aug 11, 2018
PR-URL: #22236 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe text was updated successfully, but these errors were encountered: