★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22172Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't mask descriptor.enumerable #22172

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@Trott Trott

@lpinca lpinca

@targos targos

@cjihrig cjihrig

@fesebuv fesebuv

@maclover7 maclover7

@BethGriggs BethGriggs

@gdams gdams

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
@tomleah
Copy link
Contributor

tomleah commented Aug 7, 2018

From NodeTodo //cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Aug 7, 2018

@BethGriggs

BethGriggs approved these changes Aug 7, 2018
View changes

@targos

targos approved these changes Aug 7, 2018
View changes

@fesebuv

fesebuv approved these changes Aug 7, 2018
View changes

@jasnell

jasnell approved these changes Aug 7, 2018
View changes

@cjihrig

cjihrig approved these changes Aug 7, 2018
View changes

@lpinca

lpinca approved these changes Aug 7, 2018
View changes

@Trott

Trott approved these changes Aug 8, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Aug 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16269/

@Trott Trott added the author ready label Aug 8, 2018

@gdams

gdams approved these changes Aug 8, 2018
View changes

@maclover7

maclover7 approved these changes Aug 8, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Aug 9, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16306/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Aug 9, 2018

Closer. Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16308/

Trott added a commit to Trott/io.js that referenced this pull request Aug 9, 2018

@tomleah @Trott
test: don't mask descriptor.enumerable 
PR-URL: nodejs#22172
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
2fd71f9
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Aug 9, 2018

Landed in 2fd71f9.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Aug 9, 2018

targos added a commit that referenced this pull request Aug 11, 2018

@tomleah @targos
test: don't mask descriptor.enumerable 
PR-URL: #22172
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
359605c

targos added a commit that referenced this pull request Aug 11, 2018

@tomleah @targos
test: don't mask descriptor.enumerable 
PR-URL: #22172
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
95b2467

@tomleah tomleah deleted the tomleah:remove-arg branch Aug 13, 2018

@rvagg rvagg referenced this pull request Aug 13, 2018

Merged

Release proposal: v10.9.0 #22295

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Aug 16, 2018

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.