★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22131Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: simplify state failure handling #22131

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@lpinca lpinca

@maclover7 maclover7

@ryzokuken ryzokuken

Assignees
No one assigned
Labels
C++ crypto
Projects
None yet
Milestone
No milestone
7 participants
@tniessen @nodejs-github-bot @Trott @trivikr @lpinca @maclover7 @ryzokuken
@tniessen
Copy link
Member

tniessen commented Aug 4, 2018

It is more intuitive to return true/false than undefined/false. This also simplifies handling in the JS layer and removes two control-flow branches from C++.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@tniessen
crypto: simplify state failure handling 
It is more intuitive to return true/false instead of undefined/false
and also simplifies handling in the JS layer.
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
11e0993
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ crypto labels Aug 4, 2018

@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Aug 4, 2018

cc @nodejs/crypto
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Aug 5, 2018

@nodejs/security-wg
@maclover7

maclover7 approved these changes Aug 5, 2018
View changes

@tniessen tniessen added the author ready label Aug 5, 2018

@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Aug 5, 2018 •
edited

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16200/
Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/16206/
@lpinca

lpinca approved these changes Aug 5, 2018
View changes

@ryzokuken

ryzokuken approved these changes Aug 5, 2018
View changes

Copy link
Member

ryzokuken left a comment

LGTM.
@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Aug 8, 2018

Landed in 77ac962

@trivikr trivikr closed this Aug 8, 2018

trivikr added a commit that referenced this pull request Aug 8, 2018

@tniessen @trivikr
crypto: simplify state failure handling 
It is more intuitive to return true/false instead of undefined/false
and also simplifies handling in the JS layer.

PR-URL: #22131
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Loading status checks…
77ac962

targos added a commit that referenced this pull request Aug 11, 2018

@tniessen @targos
crypto: simplify state failure handling 
It is more intuitive to return true/false instead of undefined/false
and also simplifies handling in the JS layer.

PR-URL: #22131
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
b5cf744

targos added a commit that referenced this pull request Aug 11, 2018

@tniessen @targos
crypto: simplify state failure handling 
It is more intuitive to return true/false instead of undefined/false
and also simplifies handling in the JS layer.

PR-URL: #22131
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
bef02ab

@rvagg rvagg referenced this pull request Aug 13, 2018

Merged

Release proposal: v10.9.0 #22295

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

@tniessen tniessen removed the author ready label Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.