★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22023Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix incorrect file mode check #22023

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@targos targos

@cjihrig cjihrig

@JungMinu JungMinu

@devsnek devsnek

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
10 participants
@TimothyGu @nodejs-github-bot @BridgeAR @trivikr @jasnell @lpinca @targos @cjihrig @JungMinu @devsnek
@TimothyGu
Copy link
Member

TimothyGu commented Jul 30, 2018

mode & fs.constants.S_IROTH !== 0 is in fact equivalent to mode & (fs.constants.S_IROTH !== 0).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Jul 30, 2018

@devsnek

devsnek approved these changes Jul 30, 2018
View changes

Copy link
Member

devsnek left a comment

nice catch, binop precedence always gets me
@targos

targos approved these changes Jul 30, 2018
View changes

@JungMinu

JungMinu approved these changes Jul 30, 2018
View changes

@cjihrig

cjihrig approved these changes Jul 30, 2018
View changes

@jasnell

jasnell approved these changes Jul 30, 2018
View changes

@BridgeAR

BridgeAR approved these changes Jul 30, 2018
View changes

@BridgeAR BridgeAR added fast-track author ready labels Jul 30, 2018

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Jul 30, 2018

Please +1 for fast tracking.
@lpinca

lpinca approved these changes Jul 30, 2018
View changes

@TimothyGu

This comment has been minimized.

Sign in to view
Copy link
Member Author

TimothyGu commented Jul 31, 2018 •
edited

Removing fast-tracking… forgot to run CI (oops!)

CI: https://ci.nodejs.org/job/node-test-pull-request/16103/

@TimothyGu TimothyGu removed the fast-track label Jul 31, 2018

@trivikr

trivikr approved these changes Aug 1, 2018
View changes

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Aug 3, 2018

Landed in fdbc668

@trivikr trivikr closed this Aug 3, 2018

trivikr added a commit that referenced this pull request Aug 3, 2018

@TimothyGu @trivikr
test: fix incorrect file mode check 
PR-URL: #22023
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Loading status checks…
fdbc668

targos added a commit that referenced this pull request Aug 4, 2018

@TimothyGu @targos
test: fix incorrect file mode check 
PR-URL: #22023
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6cff57e

@TimothyGu TimothyGu removed the author ready label Aug 7, 2018

@TimothyGu TimothyGu deleted the TimothyGu:file-mode-check branch Aug 7, 2018

@rvagg rvagg referenced this pull request Aug 13, 2018

Merged

Release proposal: v10.9.0 #22295

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Aug 16, 2018

Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.