★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22009Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove outdated documentation #22009

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
8 participants
@maclover7 @nodejs-github-bot @Trott @targos @jasnell @lpinca @richardlau @BridgeAR
@maclover7
Copy link
Member

maclover7 commented Jul 28, 2018

As noted by @richardlau, Makefile and vcbuild.bat no longer need to
be updated since they run the default suite.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@maclover7
test: remove outdated documentation 
As noted by @richardlau, `Makefile` and `vcbuild.bat` no longer need to
be updated since they run the `default` suite.
Loading status checks…
eafc13d
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Jul 28, 2018

@richardlau

richardlau approved these changes Jul 28, 2018
View changes

@Trott

This comment was marked as resolved.

Sign in to view
Copy link
Member

Trott commented Jul 28, 2018

Instead of removing the text, should it be updated to say to consider whether to update the default suite in test.py?
@maclover7

This comment has been minimized.

Sign in to view
Copy link
Member Author

maclover7 commented Jul 28, 2018

Instead of removing the text, should it be updated to say to consider whether to update the default suite in test.py?

The default suite is "opt out" (tools/test.py lists all directories and then removes all "ignored" ones). When adding a new test directory, tools/test.py should be able to run without any updated configuration
@lpinca

lpinca approved these changes Jul 28, 2018
View changes

@BridgeAR

BridgeAR approved these changes Jul 29, 2018
View changes

@BridgeAR BridgeAR added the author ready label Jul 29, 2018

@jasnell

jasnell approved these changes Jul 30, 2018
View changes

@maclover7

This comment has been minimized.

Sign in to view
Copy link
Member Author

maclover7 commented Jul 31, 2018

Landed in 48e1763

@maclover7 maclover7 closed this Jul 31, 2018

@maclover7 maclover7 deleted the maclover7:jm-rm-testdoc branch Jul 31, 2018

maclover7 added a commit that referenced this pull request Jul 31, 2018

@maclover7
test: remove outdated documentation 
As noted by @richardlau, `Makefile` and `vcbuild.bat` no longer need to
be updated since they run the `default` suite.

PR-URL: #22009
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
48e1763

@targos targos added backport-requested-v10.x and removed author ready labels Jul 31, 2018

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Jul 31, 2018

Depends on #21910 to land on v10.x-staging

@targos targos removed the backport-requested-v10.x label Aug 2, 2018

targos added a commit that referenced this pull request Aug 2, 2018

@maclover7 @targos
test: remove outdated documentation 
As noted by @richardlau, `Makefile` and `vcbuild.bat` no longer need to
be updated since they run the `default` suite.

PR-URL: #22009
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
e2d97ee

@rvagg rvagg referenced this pull request Aug 13, 2018

Merged

Release proposal: v10.9.0 #22295

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.