★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/22007Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: rename vm.Module to vm.SourceTextModule #22007

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Reviewers

@jdalton jdalton

@ljharb ljharb

@mcollina mcollina

@bmeck bmeck

@jasnell jasnell

@jkrems jkrems

@benjamingr benjamingr

@TimothyGu TimothyGu

@targos targos

@cjihrig cjihrig

@hiroppy hiroppy

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
build process vm
Projects
None yet
Milestone
No milestone
@devsnek
Copy link
Member

devsnek commented Jul 28, 2018

Should have always been named SourceTextModule

/cc @nodejs/vm

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnek devsnek added the vm label Jul 28, 2018

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added build process vm labels Jul 28, 2018

@devsnek

This comment has been minimized.

Sign in to view
Copy link
Member Author

devsnek commented Jul 28, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/16045/
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Jul 28, 2018

Is it in preparation for adding other kinds of modules?
@devsnek

This comment has been minimized.

Sign in to view
Copy link
Member Author

devsnek commented Jul 28, 2018 •
edited

@targos mostly... even if the spec doesn't define any more types we should still name them correctly.

@cjihrig cjihrig added the semver-major label Jul 28, 2018

@cjihrig

cjihrig approved these changes Jul 28, 2018
View changes

Copy link
Contributor

cjihrig left a comment

No opinion on the change, but the code LGTM.
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Jul 28, 2018

It doesn't have to be semver major. The API is experimental and behind a flag
@TimothyGu

TimothyGu approved these changes Jul 28, 2018
View changes

@TimothyGu TimothyGu removed the semver-major label Jul 28, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Jul 28, 2018

Not that you have to, but can you explain this? What kind of ES modules would not have some kind of source text associated with them? If this is to distinguish from e.g. WASM modules or so, maybe referring to the used language might be better?

(Also, fyi: @nodejs/modules)
@TimothyGu

This comment has been minimized.

Sign in to view
Copy link
Member

TimothyGu commented Jul 28, 2018 •
edited

@addaleax At the last TC39 meeting, a new type of Module Records backed by JavaScript source called Dynamic Module Records was discussed, and it is now at Stage 1. Regardless of whether that proposal makes it all the way into the spec, SourceTextModule is indeed a more descriptive and accurate name for what this class represents.
@ljharb

ljharb approved these changes Jul 28, 2018
View changes

@benjamingr

benjamingr approved these changes Jul 28, 2018
View changes

@jkrems

jkrems approved these changes Jul 28, 2018
View changes

@BridgeAR

BridgeAR approved these changes Jul 29, 2018
View changes

@TimothyGu

This comment has been minimized.

Sign in to view
Copy link
Member

TimothyGu commented Jul 29, 2018

@devsnek Would also be nice if my last comment (#22007 (comment)) is integrated into the commit message body.
@devsnek

This comment has been minimized.

Sign in to view
Copy link
Member Author

devsnek commented Jul 29, 2018

@TimothyGu will do when I land 👍
@mcollina

mcollina approved these changes Jul 29, 2018
View changes

Copy link
Member

mcollina left a comment

LGTM
@targos

targos approved these changes Jul 29, 2018
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Jul 29, 2018

Resumed: https://ci.nodejs.org/job/node-test-pull-request/16057/
@hiroppy

hiroppy approved these changes Jul 30, 2018
View changes

@jasnell

jasnell approved these changes Jul 30, 2018
View changes

@jdalton

jdalton approved these changes Jul 30, 2018
View changes

@bmeck

bmeck approved these changes Jul 30, 2018
View changes

@devsnek
vm: rename vm.Module to vm.SourceTextModule 
At the last TC39 meeting, a new type of Module Records backed by
JavaScript source called Dynamic Module Records was discussed, and
it is now at Stage 1. Regardless of whether that proposal makes it
all the way into the spec, SourceTextModule is indeed a more
descriptive and accurate name for what this class represents.

PR-URL: #22007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Verified
This commit was signed with a verified signature.
@devsnek devsnek Gus Caplan
GPG key ID: F00BD11880E82F0E Learn about signing commits
Loading status checks…
2bdcdfc

@devsnek devsnek force-pushed the devsnek:rename-vm-module branch from 62adcd3 to 2bdcdfc Jul 31, 2018

@devsnek devsnek closed this Jul 31, 2018

@devsnek devsnek merged commit 2bdcdfc into nodejs:master Jul 31, 2018

@devsnek devsnek deleted the devsnek:rename-vm-module branch Jul 31, 2018

@devsnek

This comment has been minimized.

Sign in to view
Copy link
Member Author

devsnek commented Jul 31, 2018

landed in 2bdcdfc

targos added a commit that referenced this pull request Aug 1, 2018

@devsnek @targos
vm: rename vm.Module to vm.SourceTextModule 
At the last TC39 meeting, a new type of Module Records backed by
JavaScript source called Dynamic Module Records was discussed, and
it is now at Stage 1. Regardless of whether that proposal makes it
all the way into the spec, SourceTextModule is indeed a more
descriptive and accurate name for what this class represents.

PR-URL: #22007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
9a88fe4

@targos targos referenced this pull request Aug 1, 2018

Merged

v10.8.0 proposal #22040

This was referenced Aug 1, 2018

Closed
Closed
Closed
Closed
Closed
Closed

@refack refack referenced this pull request Oct 18, 2018

Merged

build: spawn `make test-ci` with `-j1` #23733

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.