★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21984Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor some code around crypto::NodeBIO #21984

Closed
wants to merge 4 commits into from

Conversation

Reviewers

@apapirovski apapirovski

@jasnell jasnell

Assignees
No one assigned
Labels
C++ author ready lib / src
Projects
None yet
Milestone
No milestone
4 participants
@addaleax @nodejs-github-bot @apapirovski @jasnell
@addaleax
Copy link
Member

addaleax commented Jul 26, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ lib / src labels Jul 26, 2018

@apapirovski

apapirovski approved these changes Jul 26, 2018
View changes

@jasnell

jasnell approved these changes Jul 27, 2018
View changes

@apapirovski

This comment has been minimized.

Sign in to view
Copy link
Member

apapirovski commented Jul 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16062/

@apapirovski apapirovski added the author ready label Jul 29, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

addaleax commented Aug 1, 2018 •
edited

New CI: https://ci.nodejs.org/job/node-test-pull-request/16125/

(Edit: Windows is, once again, the final boss here.)

addaleax added some commits Jul 26, 2018

@addaleax
src: use smart pointers for NodeBIO
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
5f27653
@addaleax
src: avoid possible race during NodeBIO initialization
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
61e3eb7
@addaleax
src: remove unnecessary writes in tls_wrap.cc
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
c134e75

@addaleax addaleax removed the author ready label Aug 1, 2018

@addaleax addaleax force-pushed the addaleax:node-bio-refactor branch from 4c70d68 to c134e75 Aug 1, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

addaleax commented Aug 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16289/

@addaleax addaleax added the author ready label Aug 9, 2018

jasnell added a commit that referenced this pull request Aug 12, 2018

@addaleax @jasnell
src: use smart pointers for NodeBIO 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
987dc07

jasnell added a commit that referenced this pull request Aug 12, 2018

@addaleax @jasnell
src: avoid possible race during NodeBIO initialization 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
40ae307

jasnell added a commit that referenced this pull request Aug 12, 2018

@addaleax @jasnell
src: remove unnecessary writes in tls_wrap.cc 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
e4c4745
@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member

jasnell commented Aug 12, 2018

Landed in 987dc07, 40ae307, and e4c4745

@jasnell jasnell closed this Aug 12, 2018

rvagg added a commit that referenced this pull request Aug 13, 2018

@addaleax @rvagg
src: use smart pointers for NodeBIO 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
4590a1c

rvagg added a commit that referenced this pull request Aug 13, 2018

@addaleax @rvagg
src: avoid possible race during NodeBIO initialization 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
28d4d5f

rvagg added a commit that referenced this pull request Aug 13, 2018

@addaleax @rvagg
src: remove unnecessary writes in tls_wrap.cc 
PR-URL: #21984
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
b7c872a

@rvagg rvagg referenced this pull request Aug 13, 2018

Merged

Release proposal: v10.9.0 #22295

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed

This was referenced Aug 16, 2018

Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.