★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21931Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix sorting in the `vm.Module` section #21931

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@benjamingr benjamingr

@lpinca lpinca

Assignees
No one assigned
Labels
doc fast-track vm
Projects
None yet
Milestone
No milestone
4 participants
@vsemozhetbyt @nodejs-github-bot @benjamingr @lpinca
@vsemozhetbyt
Copy link
Member

vsemozhetbyt commented Jul 22, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Before:

1

After:

2
@nodejs-github-bot

@vsemozhetbyt vsemozhetbyt added doc vm labels Jul 22, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Jul 22, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@lpinca

lpinca approved these changes Jul 22, 2018
View changes

@benjamingr

benjamingr approved these changes Jul 22, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the fast-track label Jul 22, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Jul 22, 2018

Landed in 2ba3b57
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt closed this Jul 22, 2018

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-vm-sort branch Jul 22, 2018

vsemozhetbyt added a commit that referenced this pull request Jul 22, 2018

@vsemozhetbyt
doc: fix sorting in the `vm.Module` section 
PR-URL: #21931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Loading status checks…
2ba3b57

targos added a commit that referenced this pull request Jul 24, 2018

@vsemozhetbyt @targos
doc: fix sorting in the `vm.Module` section 
PR-URL: #21931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
5e562fd

@targos targos referenced this pull request Jul 31, 2018

Merged

v10.8.0 proposal #22040

This was referenced Aug 1, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.