test: provide better message for orphan output documentation #21913
Conversation
BridgeAR
approved these changes
Jul 20, 2018
vsemozhetbyt
approved these changes
Jul 20, 2018
This comment has been hidden.
This comment has been hidden.
cjihrig
approved these changes
Jul 20, 2018
|
Optional additional improvement for the output: There's a |
Trott
approved these changes
Jul 20, 2018
trivikr
approved these changes
Jul 22, 2018
jasnell
approved these changes
Jul 23, 2018
Trott
added a commit
to Trott/io.js
that referenced
this issue
Jul 23, 2018
PR-URL: nodejs#21913 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in c57e11c |
targos
added a commit
that referenced
this issue
Jul 24, 2018
PR-URL: #21913 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #21912
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe text was updated successfully, but these errors were encountered: