★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21872Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make getnodeversion.py python3-compatible #21872

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@Trott Trott

@addaleax addaleax

@cjihrig cjihrig

@trivikr trivikr

Assignees
No one assigned
Labels
python tools
Projects
None yet
Milestone
No milestone
7 participants
@silverwind @nodejs-github-bot @jasnell @Trott @addaleax @cjihrig @trivikr
@silverwind
Copy link
Contributor

silverwind commented Jul 18, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

When the system's python is Python 3, this script which is used during make lint failed with a syntax error. This adds print braces so it is compatible with both Python 2 and 3.
@silverwind
tools: make getnodeversion.py python3-compatible
Verified
This commit was signed with a verified signature.
@silverwind silverwind
GPG key ID: 2E62B41C93869443 Learn about signing commits
Loading status checks…
52f3df8
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the build label Jul 18, 2018

@silverwind silverwind added tools and removed build labels Jul 18, 2018

@Trott Trott added the python label Jul 18, 2018

@Trott

Trott approved these changes Jul 18, 2018
View changes

@trivikr

trivikr approved these changes Jul 19, 2018
View changes

@addaleax

addaleax approved these changes Jul 19, 2018
View changes

@jasnell

jasnell approved these changes Jul 19, 2018
View changes

@cjihrig

cjihrig approved these changes Jul 19, 2018
View changes

@silverwind

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

silverwind commented Jul 19, 2018

Thanks, landed in 287521d.

@silverwind silverwind closed this Jul 19, 2018

@silverwind silverwind deleted the silverwind:python3-getnodeversion branch Jul 19, 2018

silverwind added a commit that referenced this pull request Jul 19, 2018

@silverwind
tools: make getnodeversion.py python3-compatible 
PR-URL: #21872
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@silverwind silverwind
GPG key ID: 2E62B41C93869443 Learn about signing commits
Loading status checks…
287521d

targos added a commit that referenced this pull request Jul 20, 2018

@silverwind @targos
tools: make getnodeversion.py python3-compatible 
PR-URL: #21872
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6b925eb

@targos targos referenced this pull request Jul 31, 2018

Merged

v10.8.0 proposal #22040

This was referenced Aug 1, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.