★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21871Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: guard against cond null dereference #21871

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@benjamingr benjamingr

@cjihrig cjihrig

@mhdawson mhdawson

Assignees
No one assigned
Labels
C++ n-api
Projects
None yet
Milestone
No milestone
6 participants
@gabrielschulhof @nodejs-github-bot @benjamingr @cjihrig @mhdawson @Trott
@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jul 18, 2018

A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds tests for the
case where the queue size is zero.

Fixes: nodejs/help#1387

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ dont-land-on-v4.x n-api labels Jul 18, 2018

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 18, 2018

CI to flush out potential platform-dependent bugs: https://ci.nodejs.org/job/node-test-pull-request/15937/

@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:help-1387-tsfn-zero-queue branch from bdc2b60 to 837e716 Jul 18, 2018

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 18, 2018

Another CI after fixing syntax: https://ci.nodejs.org/job/node-test-pull-request/15938/
@mhdawson

mhdawson approved these changes Jul 18, 2018
View changes

Copy link
Member

mhdawson left a comment

LGTM

@Trott Trott removed the dont-land-on-v4.x label Jul 19, 2018

@gabrielschulhof
n-api: guard against cond null dereference 
A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds null-checks
around the condition variable and tests for the case where the queue
size is zero.

Fixes: nodejs/help#1387
Loading status checks…
6f71428

@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:help-1387-tsfn-zero-queue branch from 837e716 to 6f71428 Jul 19, 2018

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 19, 2018

Improved the commit message a bit.
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15959/
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 20, 2018

@nodejs/collaborators may I please have another review before landing this?
@cjihrig

cjihrig approved these changes Jul 23, 2018
View changes

@benjamingr

benjamingr approved these changes Jul 23, 2018
View changes

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 24, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/15986/
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 24, 2018

Landed in 53296e8.

@gabrielschulhof gabrielschulhof closed this Jul 24, 2018

gabrielschulhof added a commit that referenced this pull request Jul 24, 2018

@gabrielschulhof
n-api: guard against cond null dereference 
A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds null-checks
around the condition variable and tests for the case where the queue
size is zero.

Fixes: nodejs/help#1387
PR-URL: #21871
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Loading status checks…
53296e8

@gabrielschulhof gabrielschulhof deleted the gabrielschulhof:help-1387-tsfn-zero-queue branch Jul 24, 2018

targos added a commit that referenced this pull request Jul 24, 2018

@gabrielschulhof @targos
n-api: guard against cond null dereference 
A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds null-checks
around the condition variable and tests for the case where the queue
size is zero.

Fixes: nodejs/help#1387
PR-URL: #21871
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
45816c5

@targos targos referenced this pull request Jul 31, 2018

Merged

v10.8.0 proposal #22040

This was referenced Aug 1, 2018

Closed
Closed
Closed
Closed
Closed
Closed

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 13, 2018

@gabrielschulhof
n-api: guard against cond null dereference 
A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds null-checks
around the condition variable and tests for the case where the queue
size is zero.

Fixes: nodejs/help#1387
PR-URL: nodejs#21871
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
076c0fb

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2018

@gabrielschulhof
n-api: guard against cond null dereference 
A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds null-checks
around the condition variable and tests for the case where the queue
size is zero.

Fixes: nodejs/help#1387
PR-URL: nodejs#21871
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
7600c04

MylesBorins added a commit that referenced this pull request Jan 18, 2019

@gabrielschulhof @MylesBorins
n-api: guard against cond null dereference 
A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds null-checks
around the condition variable and tests for the case where the queue
size is zero.

Fixes: nodejs/help#1387
PR-URL: #21871
Backport-PR-URL: #25002
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
7b68d89

rvagg added a commit that referenced this pull request Feb 28, 2019

@gabrielschulhof @rvagg
n-api: guard against cond null dereference 
A condition variable is only created by the thread-safe function if the
queue size is set to something larger than zero. This adds null-checks
around the condition variable and tests for the case where the queue
size is zero.

Fixes: nodejs/help#1387
PR-URL: #21871
Backport-PR-URL: #25002
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
3675059

@MylesBorins MylesBorins referenced this pull request Mar 26, 2019

Open

v8.16.0 proposal #26933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.