Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptools: properly convert .gypi in install.py #21850
Conversation
hashseed
requested review from
bnoordhuis and
thefourtheye
Jul 17, 2018
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
build
label
Jul 17, 2018
addaleax
approved these changes
Jul 17, 2018
cjihrig
approved these changes
Jul 17, 2018
jasnell
approved these changes
Jul 17, 2018
refack
approved these changes
Jul 18, 2018
This comment has been minimized.
This comment has been minimized.
|
CI run: https://ci.nodejs.org/job/node-test-pull-request/15919/ |
This comment has been minimized.
This comment has been minimized.
refack
added
the
tools
label
Jul 18, 2018
richardlau
approved these changes
Jul 18, 2018
devsnek
approved these changes
Jul 18, 2018
thefourtheye
approved these changes
Jul 18, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed as 5e5ffc8. |
hashseed
closed this
Jul 19, 2018
targos
referenced
this pull request
Jul 20, 2018
This was referenced Aug 1, 2018
hashseed
deleted the
hashseed:gypi_parse
branch
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
hashseed commentedJul 17, 2018
It was breaking during install when .gypi strings had quotes in
them. e.g.: 'foo': 'bar="baz"'
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes