★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21832Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: avoid unnecessarily formatting a warning #21832

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@apapirovski apapirovski

@jasnell jasnell

@addaleax addaleax

@lpinca lpinca

@TimothyGu TimothyGu

@cjihrig cjihrig

@devsnek devsnek

Assignees
No one assigned
Labels
C++ fs
Projects
None yet
Milestone
No milestone
9 participants
@tniessen @nodejs-github-bot @apapirovski @jasnell @addaleax @lpinca @TimothyGu @cjihrig @devsnek
@tniessen
Copy link
Member

tniessen commented Jul 16, 2018

ProcessEmitWarning should already format the message, I think there is no need to call snprintf here.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@tniessen
src: avoid unnecessarily formatting a warning 
ProcessEmitWarning will already format the message, there is no
need to call snprintf here.
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
a05ad54

@tniessen tniessen requested a review from jasnell Jul 16, 2018

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ fs labels Jul 16, 2018

@apapirovski

apapirovski approved these changes Jul 16, 2018
View changes

@cjihrig

cjihrig approved these changes Jul 16, 2018
View changes

@devsnek

devsnek approved these changes Jul 16, 2018
View changes

@TimothyGu

TimothyGu approved these changes Jul 16, 2018
View changes

@addaleax

addaleax approved these changes Jul 16, 2018
View changes

@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Jul 17, 2018

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15904/

@tniessen tniessen added the author ready label Jul 17, 2018

@lpinca

lpinca approved these changes Jul 17, 2018
View changes

@jasnell

jasnell approved these changes Jul 17, 2018
View changes

tniessen added a commit that referenced this pull request Jul 18, 2018

@tniessen
src: avoid unnecessarily formatting a warning 
ProcessEmitWarning will already format the message, there is no
need to call snprintf here.

PR-URL: #21832
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
7b6e2fc
@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Jul 18, 2018

Landed in 7b6e2fc.

@tniessen tniessen closed this Jul 18, 2018

targos added a commit that referenced this pull request Jul 19, 2018

@tniessen @targos
src: avoid unnecessarily formatting a warning 
ProcessEmitWarning will already format the message, there is no
need to call snprintf here.

PR-URL: #21832
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c45623a

@targos targos referenced this pull request Jul 31, 2018

Merged

v10.8.0 proposal #22040

This was referenced Aug 1, 2018

Closed
Closed
Closed
Closed
Closed
Closed

@tniessen tniessen removed the author ready label Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.