★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21750Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: named anonymous functions in _stream_readable.js #21750

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
author ready stream
Projects
None yet
Milestone
No milestone
6 participants
@radsimu @trivikr @BridgeAR @jasnell @lpinca @nodejs-github-bot
@radsimu
Copy link
Contributor

radsimu commented Jul 11, 2018 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream label Jul 11, 2018

@jasnell

jasnell approved these changes Jul 11, 2018
View changes

@trivikr

trivikr approved these changes Jul 11, 2018
View changes

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Jul 11, 2018 •
edited

Thank you @radsimu for your first PR to Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15796/

@trivikr trivikr added the author ready label Jul 11, 2018

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Jul 11, 2018

ToDo while pushing the code: rename http to stream in commit message
@lpinca

lpinca approved these changes Jul 12, 2018
View changes

@jasnell

jasnell approved these changes Jul 12, 2018
View changes

@BridgeAR

BridgeAR approved these changes Jul 12, 2018
View changes

@BridgeAR BridgeAR changed the title http: named anonymous functions in _stream_readable.js stream: named anonymous functions in _stream_readable.js Jul 12, 2018

@trivikr

This comment has been minimized.

Sign in to view
Copy link
Contributor

trivikr commented Jul 18, 2018

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/15927/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jul 18, 2018

@radsimu @BridgeAR
stream: named anonymous functions in _stream_readable.js 
PR-URL: nodejs#21750
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
7e4e04d
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Jul 18, 2018

Landed in 7e4e04d

@radsimu congratulations on your first commit to Node.js! 🎉 Keep it coming :-)

@BridgeAR BridgeAR closed this Jul 18, 2018

targos added a commit that referenced this pull request Jul 19, 2018

@radsimu @targos
stream: named anonymous functions in _stream_readable.js 
PR-URL: #21750
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
d0c16f4

@targos targos referenced this pull request Jul 31, 2018

Merged

v10.8.0 proposal #22040

This was referenced Aug 1, 2018

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.