Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updeps: patch V8 to 6.7.288.49 #21727
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
V8 Engine
label
Jul 9, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It doesn’t look like these changes affect us, right? I guess it’s not an issue if you’re a Googler, but if your dev machine is near the lower end, recompiling all of V8 can be a real pain… |
This comment has been minimized.
This comment has been minimized.
|
@addaleax we can hold off on landing this one and wait for changes that are more meaningful, generally trying to just keep us up to date with LKGR. Do these changes force a recompile? |
This comment has been minimized.
This comment has been minimized.
I guess not, no … seems okay to me then? |
addaleax
approved these changes
Jul 9, 2018
ChALkeR
approved these changes
Jul 11, 2018
BridgeAR
approved these changes
Jul 13, 2018
BridgeAR
added
the
author ready
label
Jul 13, 2018
This comment has been minimized.
This comment has been minimized.
|
landed in 9374a83 |
MylesBorins
closed this
Jul 13, 2018
MylesBorins
added a commit
that referenced
this pull request
Jul 13, 2018
targos
added a commit
that referenced
this pull request
Jul 14, 2018
This was referenced Jul 18, 2018
MylesBorins
added
the
dont-land-on-v8.x
label
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MylesBorins commentedJul 9, 2018
Refs: v8/v8@6.7.288.46...6.7.288.49