★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21699Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: consolidate redundant require() calls #21699

Merged
merged 1 commit into from Jul 10, 2018
Merged

lib: consolidate redundant require() calls #21699

merged 1 commit into from Jul 10, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jul 7, 2018

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/219/pipeline

Trott
Trott approved these changes Jul 7, 2018
View changes
@Trott
Copy link
Member

@Trott Trott commented Jul 7, 2018

Another spurious linter error that only seems to show up in auto-started linter jobs.

targos
targos approved these changes Jul 7, 2018
View changes
devsnek
devsnek approved these changes Jul 8, 2018
View changes
@cjihrig
lib: consolidate redundant require() calls
573744c 
PR-URL: nodejs#21699
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@cjihrig
Copy link
Contributor Author

@cjihrig cjihrig commented Jul 10, 2018

CI with one flake that failed: https://ci.nodejs.org/job/node-test-pull-request/15776/

@cjihrig cjihrig merged commit 573744c into nodejs:master Jul 10, 2018
2 checks passed
@cjihrig cjihrig deleted the no-dup-reqs branch Jul 10, 2018
targos added a commit that referenced this issue Jul 10, 2018
@cjihrig @targos
lib: consolidate redundant require() calls
92d7921 
PR-URL: #21699
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@targos targos mentioned this pull request Jul 17, 2018
Merged
@beevelop beevelop mentioned this pull request Jul 18, 2018
Closed
@beevelop beevelop mentioned this pull request Jul 18, 2018
Closed
@beevelop beevelop mentioned this pull request Jul 18, 2018
Closed
@beevelop beevelop mentioned this pull request Jul 19, 2018
Closed
@beevelop beevelop mentioned this pull request Jul 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@targos targos

@maclover7 maclover7

@JungMinu JungMinu

@devsnek devsnek

@fosslinux fosslinux

Assignees
No one assigned
Labels
lib / src
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
8 participants
@cjihrig @nodejs-github-bot @Trott @targos @maclover7 @JungMinu @devsnek @fosslinux