★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21688Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: create functions directly #21688

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@kfarnung kfarnung

@TimothyGu TimothyGu

@hashseed hashseed

@cjihrig cjihrig

@devsnek devsnek

Assignees
No one assigned
Labels
C++ n-api
Projects
None yet
Milestone
No milestone
8 participants
@gabrielschulhof @nodejs-github-bot @addaleax @kfarnung @TimothyGu @hashseed @cjihrig @devsnek
@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jul 6, 2018

Avoid using v8::FunctionTemplate::New() when using
v8::Function::New() suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ dont-land-on-v4.x n-api labels Jul 6, 2018

@gabrielschulhof gabrielschulhof requested review from TimothyGu, addaleax and hashseed Jul 6, 2018

@gabrielschulhof gabrielschulhof referenced this pull request Jul 6, 2018

Open

AsyncWorker structural defects and limitations #231

@devsnek

devsnek approved these changes Jul 6, 2018
View changes

@hashseed

hashseed approved these changes Jul 6, 2018
View changes

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15749/
@addaleax

addaleax approved these changes Jul 6, 2018
View changes

@kfarnung

kfarnung approved these changes Jul 6, 2018
View changes

@cjihrig

cjihrig approved these changes Jul 7, 2018
View changes

@TimothyGu

TimothyGu approved these changes Jul 8, 2018
View changes

@gabrielschulhof gabrielschulhof referenced this pull request Jul 8, 2018

Merged

v8.12.0 proposal #21593

@gabrielschulhof
n-api: create functions directly 
Avoid using `v8::FunctionTemplate::New()` when using
`v8::Function::New()` suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.
Loading status checks…
bde34a1

@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:switch-to-v8-function-new branch from 2ba170d to bde34a1 Jul 9, 2018

@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 9, 2018

Rebase and CI before landing: https://ci.nodejs.org/job/node-test-pull-request/15766/
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Jul 9, 2018

Landed in 978d89f.

@gabrielschulhof gabrielschulhof closed this Jul 9, 2018

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Jul 9, 2018

@gabrielschulhof
n-api: create functions directly 
Avoid using `v8::FunctionTemplate::New()` when using
`v8::Function::New()` suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.

PR-URL: nodejs#21688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
978d89f

@gabrielschulhof gabrielschulhof deleted the gabrielschulhof:switch-to-v8-function-new branch Jul 9, 2018

targos added a commit that referenced this pull request Jul 10, 2018

@gabrielschulhof @targos
n-api: create functions directly 
Avoid using `v8::FunctionTemplate::New()` when using
`v8::Function::New()` suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.

PR-URL: #21688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
109c599

@targos targos referenced this pull request Jul 17, 2018

Merged

v10.7.0 proposal #21851

This was referenced Jul 18, 2018

Closed
Closed
Closed
Closed
Closed

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Aug 8, 2018

@gabrielschulhof
n-api: create functions directly 
Avoid using `v8::FunctionTemplate::New()` when using
`v8::Function::New()` suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.

PR-URL: nodejs#21688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
71effc9

@gabrielschulhof gabrielschulhof referenced this pull request Aug 8, 2018

Closed

[v8.x-backport] n-api: create functions directly #22202

3 of 3 tasks complete

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Aug 10, 2018

@gabrielschulhof
n-api: create functions directly 
Avoid using `v8::FunctionTemplate::New()` when using
`v8::Function::New()` suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.

PR-URL: nodejs#21688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
24610d6

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Aug 16, 2018

@gabrielschulhof
n-api: create functions directly 
Avoid using `v8::FunctionTemplate::New()` when using
`v8::Function::New()` suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.

PR-URL: nodejs#21688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
3078ccf

MylesBorins added a commit that referenced this pull request Aug 17, 2018

@gabrielschulhof @MylesBorins
n-api: create functions directly 
Avoid using `v8::FunctionTemplate::New()` when using
`v8::Function::New()` suffices. This ensures that individual functions
can be gc-ed and that functions can be created dynamically without
running out of memory.

Backport-PR-URL: #22202
PR-URL: #21688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
35a8ff7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.