Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: fix HTTP res 'finish' description #21670
Conversation
nodejs-github-bot
added
doc
http
labels
Jul 5, 2018
This comment has been minimized.
This comment has been minimized.
|
And one thought in addition to that: before #21047
Probably it is worth to be mentioned somewhere in documentation. |
jasnell
approved these changes
Jul 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in f386c7e |
addaleax
closed this
Jul 10, 2018
addaleax
added a commit
that referenced
this pull request
Jul 10, 2018
targos
added a commit
that referenced
this pull request
Jul 12, 2018
This was referenced Jul 18, 2018
Trott
referenced this pull request
Aug 11, 2018
Closed
doc: require two approvals to land changes #22255
refack
referenced this pull request
Oct 18, 2018
Merged
build: spawn `make test-ci` with `-j1` #23733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tadjik1 commentedJul 5, 2018
In addition to #21047, after #20611
closeevent will be emitted on response object afterfinish.Checklist