★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21506Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for missing dynamic instantiate hook #21506

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@benjamingr benjamingr

@devsnek devsnek

Assignees
No one assigned
Labels
ES Modules test
Projects
None yet
Milestone
No milestone
5 participants
@targos @nodejs-github-bot @jasnell @benjamingr @devsnek
@targos
Copy link
Member

targos commented Jun 24, 2018 •
edited

Depends on:
#21352
#21493

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@targos targos added test blocked ES Modules labels Jun 24, 2018

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Jun 24, 2018

@targos targos added the work in progress (WIP) label Jun 24, 2018

@benjamingr

benjamingr approved these changes Jun 24, 2018
View changes

Copy link
Member

benjamingr left a comment

LGTM given the other two land
@jasnell

jasnell approved these changes Jun 24, 2018
View changes

@targos
test: add test for missing dynamic instantiate hook
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
543142f

@targos targos force-pushed the targos:test-add-esm-missing-dyn branch from 6116551 to 543142f Jun 30, 2018

@targos

This comment has been minimized.

Sign in to view
Copy link
Member Author

targos commented Jun 30, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/15694/
Edit: new Linux run: https://ci.nodejs.org/job/node-test-commit-linux/19892/
@devsnek

devsnek approved these changes Jun 30, 2018
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member Author

targos commented Jul 3, 2018

Landed in 908518d

@targos targos closed this Jul 3, 2018

@targos targos deleted the targos:test-add-esm-missing-dyn branch Jul 3, 2018

@targos targos removed work in progress (WIP) blocked labels Jul 3, 2018

targos added a commit that referenced this pull request Jul 3, 2018

@targos
test: add test for missing dynamic instantiate hook 
PR-URL: #21506
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
908518d

targos added a commit that referenced this pull request Jul 4, 2018

@targos
test: add test for missing dynamic instantiate hook 
PR-URL: #21506
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
9cd5c0e

@targos targos referenced this pull request Jul 17, 2018

Merged

v10.7.0 proposal #21851

This was referenced Jul 18, 2018

Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.