lib: name anonymous callbacks
This commit is to help in the effort to name all anonymous functions to help when heap debugging. Specifically, this commit fixes some anonymous functions used as listeners in the lib/ folder. Refs: #8913

This commit is to help in the effort to name all anonymous functions to help when heap debugging. Specifically, this commit fixes some anonymous functions used as listeners in the lib/ folder. Refs: #8913
Improved naming
nodejs · mlrv · mlrv · mlrv · Jun 19, 2018 · nodejs-github-bot
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
@@ -240,7 +240,7 @@ exports.translatePeerCertificate = function translatePeerCertificate(c) {
    c.infoAccess = Object.create(null);

    // XXX: More key validation?
-    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function(all, key, val) {
+    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function replacerCallback(all, key, val) {
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -721,7 +721,7 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
 };

 function pipeOnDrain(src) {
-  return function() {
+  return function pipeOnDrainInner() {
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -185,7 +185,7 @@ OutgoingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
  }

  if (!this.socket) {
-    this.once('socket', function(socket) {
+    this.once('socket', function socketOnceCallback(socket) {
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -202,7 +202,7 @@ OutgoingMessage.prototype.destroy = function destroy(error) {
  if (this.socket) {
    this.socket.destroy(error);
  } else {
-    this.once('socket', function(socket) {
+    this.once('socket', function socketOnceCallback(socket) {
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
@@ -240,7 +240,7 @@ exports.translatePeerCertificate = function translatePeerCertificate(c) {
    c.infoAccess = Object.create(null);

    // XXX: More key validation?
-    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function(all, key, val) {
+    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function replacerCallback(all, key, val) {
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
@@ -240,7 +240,7 @@ exports.translatePeerCertificate = function translatePeerCertificate(c) {
    c.infoAccess = Object.create(null);

    // XXX: More key validation?
-    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function (all, key, val) {
+    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function(all, key, val) {