★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/20430Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: doc cleanup #20430

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@gabrielschulhof gabrielschulhof

@cjihrig cjihrig

@trivikr trivikr

Assignees
No one assigned
Labels
author ready doc dont-land-on-v6.x fast-track land-on-v8.x n-api
Projects
None yet
Milestone
No milestone
8 participants
@mhdawson @vsemozhetbyt @gabrielschulhof @jasnell @cjihrig @trivikr @MylesBorins @nodejs-github-bot
@mhdawson
Copy link
Member

mhdawson commented Apr 30, 2018 •
edited

Partial doc cleanup as per
#20421

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc dont-land-on-v4.x dont-land-on-v6.x n-api labels Apr 30, 2018

@mhdawson mhdawson referenced this pull request Apr 30, 2018

Closed

N-API documentation needs review (misleading / wrong code samples, etc) #20421

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Apr 30, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track label Apr 30, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Apr 30, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/637/
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Apr 30, 2018

(nit: on landing, the commit message title needs to be changed into doc: cleanup doc or maybe doc: cleanup n-api.md.)

@vsemozhetbyt vsemozhetbyt referenced this pull request Apr 30, 2018

Closed

n-api: fix napi_property_descriptor documentation #20433

3 of 3 tasks complete
@mhdawson

This comment has been minimized.

Sign in to view
Copy link
Member Author

mhdawson commented Apr 30, 2018

@gabrielf can you review this one.
@trivikr

trivikr approved these changes May 1, 2018
View changes

@gabrielschulhof

gabrielschulhof approved these changes May 2, 2018
View changes

Copy link
Contributor

gabrielschulhof left a comment

LGTM
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor

gabrielschulhof commented May 2, 2018

nit: s/Partical/Partial/ in the commit message.

@trivikr trivikr added the author ready label May 3, 2018

@cjihrig

cjihrig approved these changes May 3, 2018
View changes

@jasnell

jasnell approved these changes May 3, 2018
View changes

@mhdawson
doc: cleanup n-api.md doc 
Partial doc cleanup as per
#20421
ab58ab1

@mhdawson mhdawson force-pushed the mhdawson:napi-doc100 branch from 9e0a28a to ab58ab1 May 3, 2018

@mhdawson

This comment has been minimized.

Sign in to view
Copy link
Member Author

mhdawson commented May 3, 2018

Fixed up commit comment, previous CI run looked good, will land.
@mhdawson

This comment has been minimized.

Sign in to view
Copy link
Member Author

mhdawson commented May 3, 2018

Landed as 4740e5d

@mhdawson mhdawson closed this May 3, 2018

mhdawson added a commit that referenced this pull request May 3, 2018

@mhdawson
doc: cleanup n-api.md doc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
4740e5d

MylesBorins added a commit that referenced this pull request May 4, 2018

@mhdawson @MylesBorins
doc: cleanup n-api.md doc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
36d93da

@MylesBorins MylesBorins referenced this pull request May 8, 2018

Merged

v10.1.0 proposal #20606

MylesBorins added a commit that referenced this pull request May 8, 2018

@mhdawson @MylesBorins
doc: cleanup n-api.md doc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
b2d6eb7

shisama added a commit to shisama/node that referenced this pull request May 9, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
3f482bb

shisama added a commit to shisama/node that referenced this pull request May 10, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
a94dca7

shisama added a commit to shisama/node that referenced this pull request May 13, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
1a7f366

shisama added a commit to shisama/node that referenced this pull request May 13, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
c282426

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
a7e7bcf

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
149617b

shisama added a commit to shisama/node that referenced this pull request Jun 5, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2cffa92

shisama added a commit to shisama/node that referenced this pull request Jun 9, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
fc47e90

shisama added a commit to shisama/node that referenced this pull request Jun 11, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
50075ad

shisama added a commit to shisama/node that referenced this pull request Jun 12, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
0c9d979

shisama added a commit to shisama/node that referenced this pull request Jun 17, 2018

@mhdawson @shisama
doc: cleanup n-api.md doc 
Partial doc cleanup as per
nodejs#20421

PR-URL: nodejs#20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
5fe6fe3

@mhdawson mhdawson referenced this pull request Jul 4, 2018

Merged

v8.12.0 proposal #21593

@MylesBorins MylesBorins added the land-on-v8.x label Jul 9, 2018

MylesBorins added a commit that referenced this pull request Jul 9, 2018

@mhdawson @MylesBorins
doc: cleanup n-api.md doc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
6eec3fc

MylesBorins added a commit that referenced this pull request Jul 10, 2018

@mhdawson @MylesBorins
doc: cleanup n-api.md doc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
f4b9985

rvagg added a commit that referenced this pull request Aug 16, 2018

@mhdawson @rvagg
doc: cleanup n-api.md doc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
4709734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.