vm: add Script.createCodeCache()

vm: add Script.createCodeCache()
PR-URL: #20300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>
PR-URL: #20300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org>
nodejs · devsnek · devsnek · devsnek · Apr 25, 2018 · devsnek
diff --git a/lib/vm.js b/lib/vm.js
+    if (cachedData && !cachedDataWarned) {
+      process.emitWarning(cachedDataMessage, 'DeprecationWarning', 'DEPXXXX');
+      cachedDataWarned = true;
+    }
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
+
+Type: Documentation-only
+
+The options `produceCachedData` and `cachedData` have been deprecated. Please use
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
+          env,
+          reinterpret_cast<const char*>(cached_data->data),
+          cached_data->length);
+      args.GetReturnValue().Set(buf.ToLocalChecked());
diff --git a/src/env.h b/src/env.h
  V(change_string, "change")                                                  \
  V(channel_string, "channel")                                                \
  V(chunks_sent_since_last_write_string, "chunksSentSinceLastWrite")          \
+  V(code_cache_used_string, "codeCacheUsed")                                  \
diff --git a/doc/api/vm.md b/doc/api/vm.md
+  * `codeCache` {Buffer} Provides an optional `Buffer` with V8's code cache
+    data for the supplied source. When supplied, the `codeCacheRejected` value
+    will be set to either `true` or `false` depending on acceptance of the data
+    by V8.
  * `cachedData` {Buffer} Provides an optional `Buffer` with V8's code cache
diff --git a/doc/api/vm.md b/doc/api/vm.md
+-->
+
+Creates a code cache that can be used with the Script constructor's
+`cachedData` option. Returns a Buffer. If the code cache cannot be created then
diff --git a/doc/api/vm.md b/doc/api/vm.md
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/20300
+    description: The `produceCachedData` is deprecated in favour of
+                 `script.createCachedData()`
diff --git a/doc/api/vm.md b/doc/api/vm.md
+
+Creates a code cache that can be used with the Script constructor's
+`cachedData` option. Returns a Buffer. If the code cache cannot be created then
+`ERR_CODE_CACHE_CREATION_FAILED` is thrown. This method may be called at any
diff --git a/doc/api/vm.md b/doc/api/vm.md
+Creates a code cache that can be used with the Script constructor's
+`cachedData` option. Returns a Buffer. If the code cache cannot be created then
+`ERR_CODE_CACHE_CREATION_FAILED` is thrown. This method may be called at any
+time and any number of times.
diff --git a/test/parallel/test-vm-cached-data.js b/test/parallel/test-vm-cached-data.js

-      if (script.cachedDataProduced)
-        data = script.cachedData.toString('base64');
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
+<a id="DEP00XX"></a>
+### DEP00XX: vm.Script cached data
+
+Type: Documentation-only
diff --git a/test/parallel/test-vm-cached-data.js b/test/parallel/test-vm-cached-data.js
+
+      assert(cachedData instanceof Buffer);
+
+      data = cachedData.toString('base64');