★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/19689Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: do not identify string as "JavaScript string" #19689

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Mar 30, 2018

A parameter that is explicitly identified as a string does not need to
be further specified in the text as a "JavaScript string". Remove the
type altogether as it is indicated in the argument description.

Checklist
@Trott
doc: do not identify string as "JavaScript string" 
A parameter that is explicitly identified as a string does not need to
be further specified in the text as a "JavaScript string". Remove the
type altogether as it is indicated in the argument description.
Loading status checks…
642f683

@nodejs-github-bot nodejs-github-bot added buffer doc labels Mar 30, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 30, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/13939/
@TimothyGu
TimothyGu approved these changes Mar 30, 2018
View changes
@lpinca
lpinca approved these changes Mar 30, 2018
View changes

@lpinca lpinca added the author ready label Mar 30, 2018

@ChALkeR
ChALkeR approved these changes Mar 30, 2018
View changes
@trivikr
trivikr approved these changes Mar 30, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the fast-track label Mar 30, 2018

@vsemozhetbyt
vsemozhetbyt approved these changes Mar 30, 2018
View changes
@tniessen
tniessen approved these changes Mar 30, 2018
View changes
@cjihrig
cjihrig approved these changes Mar 30, 2018
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 2, 2018

LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite/381/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 2, 2018

Landed in a3160b7

@Trott Trott closed this Apr 2, 2018

Trott added a commit to Trott/io.js that referenced this pull request Apr 2, 2018
@Trott
doc: do not identify string as "JavaScript string" 
A parameter that is explicitly identified as a string does not need to
be further specified in the text as a "JavaScript string". Remove the
type altogether as it is indicated in the argument description.

PR-URL: nodejs#19689
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
a3160b7
targos added a commit that referenced this pull request Apr 2, 2018
@Trott @targos
doc: do not identify string as "JavaScript string" 
A parameter that is explicitly identified as a string does not need to
be further specified in the text as a "JavaScript string". Remove the
type altogether as it is indicated in the argument description.

PR-URL: #19689
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
3a3ae01
@targos targos referenced this pull request Apr 4, 2018
Merged
BethGriggs added a commit that referenced this pull request Dec 4, 2018
@Trott @BethGriggs
doc: do not identify string as "JavaScript string" 
A parameter that is explicitly identified as a string does not need to
be further specified in the text as a "JavaScript string". Remove the
type altogether as it is indicated in the argument description.

PR-URL: #19689
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
216e7da
@BethGriggs BethGriggs referenced this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR

@lpinca lpinca

@TimothyGu TimothyGu

@cjihrig cjihrig

@tniessen tniessen

@vsemozhetbyt vsemozhetbyt

@trivikr trivikr

Assignees
No one assigned
Labels
author ready buffer doc fast-track
Projects
None yet
Milestone
No milestone
9 participants
@Trott @ChALkeR @lpinca @TimothyGu @cjihrig @tniessen @vsemozhetbyt @trivikr @nodejs-github-bot
You can’t perform that action at this time.