★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/19636Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use createReadStream instead of ReadStream #19636

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Mar 27, 2018

This commit updates test-fs-read-stream to use fs.createReadStream
instead of using fs.ReadStream. All other places in this test use
the former.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev
test: use createReadStream instead of ReadStream 
This commit updates test-fs-read-stream to use fs.createReadStream
instead of using fs.ReadStream. All other places in this test use
the former.
Loading status checks…
58314c8

@nodejs-github-bot nodejs-github-bot added the test label Mar 27, 2018

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13889/
@cjihrig
cjihrig approved these changes Mar 27, 2018
View changes
@lpinca
lpinca approved these changes Mar 27, 2018
View changes
@trivikr
trivikr approved these changes Mar 27, 2018
View changes
@starkwang
starkwang approved these changes Mar 28, 2018
View changes
@jasnell
jasnell approved these changes Mar 28, 2018
View changes
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 29, 2018

Landed in aec0190.

@danbev danbev closed this Mar 29, 2018

@danbev danbev deleted the danbev:test_fs_read_stream_createReadStream branch Mar 29, 2018

danbev added a commit that referenced this pull request Mar 29, 2018
@danbev
test: use createReadStream instead of ReadStream 
This commit updates test-fs-read-stream to use fs.createReadStream
instead of using fs.ReadStream. All other places in this test use
the former.

PR-URL: #19636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aec0190
targos added a commit that referenced this pull request Apr 2, 2018
@danbev @targos
test: use createReadStream instead of ReadStream 
This commit updates test-fs-read-stream to use fs.createReadStream
instead of using fs.ReadStream. All other places in this test use
the former.

PR-URL: #19636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
94b28aa
@targos targos referenced this pull request Apr 4, 2018
Merged
BethGriggs added a commit that referenced this pull request Dec 4, 2018
@danbev @BethGriggs
test: use createReadStream instead of ReadStream 
This commit updates test-fs-read-stream to use fs.createReadStream
instead of using fs.ReadStream. All other places in this test use
the former.

PR-URL: #19636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
3ca10fa
@BethGriggs BethGriggs referenced this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@starkwang starkwang

@trivikr trivikr

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
7 participants
@danbev @jasnell @lpinca @cjihrig @starkwang @trivikr @nodejs-github-bot
You can’t perform that action at this time.